From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org, v4l-dvb-maintainer@linuxtv.org
Subject: [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static
Date: Sat, 4 Mar 2006 13:14:26 +0100 [thread overview]
Message-ID: <20060304121426.GL9295@stusta.de> (raw)
In-Reply-To: <20060303045651.1f3b55ec.akpm@osdl.org>
On Fri, Mar 03, 2006 at 04:56:51AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc5-mm1:
>...
> git-dvb.patch
>...
> git trees
>...
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/video/msp3400-kthreads.c | 6 +++---
drivers/media/video/msp3400.h | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400.h.old 2006-03-03 17:40:22.000000000 +0100
+++ linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400.h 2006-03-03 17:40:41.000000000 +0100
@@ -104,7 +104,6 @@
/* msp3400-kthreads.c */
const char *msp_standard_std_name(int std);
-void msp_set_source(struct i2c_client *client, u16 src);
void msp_set_audmode(struct i2c_client *client);
void msp_detect_stereo(struct i2c_client *client);
int msp3400c_thread(void *data);
--- linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400-kthreads.c.old 2006-03-03 17:39:29.000000000 +0100
+++ linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400-kthreads.c 2006-03-03 17:40:10.000000000 +0100
@@ -154,7 +154,7 @@
return "unknown";
}
-void msp_set_source(struct i2c_client *client, u16 src)
+static void msp_set_source(struct i2c_client *client, u16 src)
{
struct msp_state *state = i2c_get_clientdata(client);
@@ -217,7 +217,7 @@
/* Set audio mode. Note that the pre-'G' models do not support BTSC+SAP,
nor do they support stereo BTSC. */
-void msp3400c_set_audmode(struct i2c_client *client)
+static void msp3400c_set_audmode(struct i2c_client *client)
{
static char *strmode[] = { "mono", "stereo", "lang2", "lang1" };
struct msp_state *state = i2c_get_clientdata(client);
@@ -944,7 +944,7 @@
status, is_stereo, is_bilingual, state->rxsubchans);
}
-void msp34xxg_set_audmode(struct i2c_client *client)
+static void msp34xxg_set_audmode(struct i2c_client *client)
{
struct msp_state *state = i2c_get_clientdata(client);
int source;
next prev parent reply other threads:[~2006-03-04 12:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 12:56 2.6.16-rc5-mm2 Andrew Morton
2006-03-03 15:26 ` 2.6.16-rc5-mm2: IPW_QOS: two remarks Adrian Bunk
2006-03-05 0:46 ` Andreas Happe
2006-03-07 17:06 ` Adrian Bunk
2006-03-17 19:14 ` John W. Linville
2006-03-18 17:47 ` [PATCH 2.6.16-rc6 1/1] ipw2200: Add Kconfig entries for QOS and Monitor mode Andreas Happe
2006-03-22 3:11 ` Zhu Yi
2006-03-03 16:08 ` 2.6.16-rc5-mm2 (mips compile fix) Jason Baron
2006-03-03 17:08 ` 2.6.16-rc5-mm2 Benoit Boissinot
2006-03-04 1:34 ` 2.6.16-rc5-mm2 Grant Coady
2006-03-05 6:26 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-05 7:24 ` 2.6.16-rc5-mm2 Mike Galbraith
2006-03-06 11:35 ` 2.6.16-rc5-mm2 Takashi Iwai
2006-03-05 12:34 ` 2.6.16-rc5-mm2 Antonino A. Daplas
2006-03-04 12:14 ` [-mm patch] drivers/acpi/bus.c: make struct acpi_sci_dir static Adrian Bunk
2006-03-04 12:14 ` Adrian Bunk [this message]
2006-03-04 12:14 ` [RFC: -mm patch] drivers/message/fusion/mptbase.c: make mpt_read_ioc_pg_3() static Adrian Bunk
2006-03-04 12:14 ` [-mm patch] kernel/futex.c: make futexfs_get_sb() static again Adrian Bunk
2006-03-06 14:44 ` David Howells
2006-03-04 12:14 ` [-mm patch] mm/bootmem.c: make bdata_list static Adrian Bunk
2006-03-04 12:14 ` [-mm patch] NFS: make 2 functions static Adrian Bunk
2006-03-04 12:14 ` [RFC: -mm patch] fs/locks.c: make posix_locks_deadlock() static Adrian Bunk
2006-03-04 17:29 ` 2.6.16-rc5-mm2 Mattia Dongili
2006-03-05 6:28 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-05 8:14 ` 2.6.16-rc5-mm2 Benoit Boissinot
2006-03-05 8:34 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-05 11:42 ` 2.6.16-rc5-mm2 Stefan Rompf
2006-03-06 15:22 ` 2.6.16-rc5-mm2 James Ketrenos
2006-03-05 22:54 ` 2.6.16-rc5-mm2 Dominik Karall
2006-03-07 5:43 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-07 10:43 ` 2.6.16-rc5-mm2 David Howells
2006-03-07 14:33 ` 2.6.16-rc5-mm2 Dominik Karall
2006-03-07 17:25 ` 2.6.16-rc5-mm2 john stultz
2006-03-08 1:13 ` 2.6.16-rc5-mm2 Andi Kleen
2006-03-06 8:45 ` 2.6.16-rc5-mm2 Cornelia Huck
2006-03-06 9:10 ` 2.6.16-rc5-mm2 compile error in urb.c Helge Hafting
2006-03-06 9:21 ` Andrew Morton
2006-03-06 12:17 ` Helge Hafting
-- strict thread matches above, loose matches on Subject: below --
2006-03-08 9:08 [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static Adrian Bunk
2006-03-08 18:46 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060304121426.GL9295@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox