Re: [PATCH 01/13] RTC Subsystem, library functions

Alessandro Zummo
2006-03-04T17:13:15Z

On Sat, 4 Mar 2006 17:58:43 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> > +# RTC class/drivers configuration
> > +#
> > +
> > +config RTC_LIB
> > + bool
> >...
>
> What about
>
> config RTC_LIB
> tristate
>
> and
>
> obj-$(CONFIG_RTC_LIB) += rtc-lib.o
>
> ?

The rtc library code is selected also by code that goes in
arch specific code (arm, for example). I'm not sure it will appropriate
to use it as a module.

> IOW:
> Is there anything besides adding a MODULE_LICENSE("GPL"); required for
> allowing an rtc-lib module?

I think MODULE_LICENSE("GPL") should be enough.

> > --- linux-rtc.orig/drivers/Makefile 2006-02-28 13:16:34.000000000 +0100
> > +++ linux-rtc/drivers/Makefile 2006-02-28 13:16:36.000000000 +0100
> > @@ -56,6 +56,7 @@ obj-$(CONFIG_USB_GADGET) += usb/gadget/
> > obj-$(CONFIG_GAMEPORT) += input/gameport/
> > obj-$(CONFIG_INPUT) += input/
> > obj-$(CONFIG_I2O) += message/
> > +obj-y += rtc/
> >...
>
> obj-$(CONFIG_RTC_LIB) += rtc/
>
> should be possible since RTC_CLASS select's RTC_LIB.

probably yes. will change.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Turin, Italy