From: Matthew Garrett <mjg59@srcf.ucam.org>
To: mactel-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] /sys/firmware/efi/systab giving incorrect value for smbios
Date: Sat, 4 Mar 2006 18:00:18 +0000 [thread overview]
Message-ID: <20060304180018.GA3695@srcf.ucam.org> (raw)
On my Intel imac, /sys/firmware/efi/systab is the following:
ACPI20=0x1fefd014
ACPI=0x1fefd000
SMBIOS=0x9fec9000
if I have a kernel with a 2:2 user/kernel split, and
SMBIOS=0x5fec9000
if I have a kernel with a 3:1 split. The correct value is 0x1fec9000,
which is what the kernel prints at boot time. The following trivial
patch seems to fix things.
Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
diff --git a/arch/i386/kernel/efi.c b/arch/i386/kernel/efi.c
index ecad519..6be705e 100644
--- a/arch/i386/kernel/efi.c
+++ b/arch/i386/kernel/efi.c
@@ -391,7 +391,7 @@ void __init efi_init(void)
printk(KERN_INFO " ACPI=0x%lx ", config_tables[i].table);
} else
if (efi_guidcmp(config_tables[i].guid, SMBIOS_TABLE_GUID) == 0) {
- efi.smbios = (void *) config_tables[i].table;
+ efi.smbios = __va(config_tables[i].table);
printk(KERN_INFO " SMBIOS=0x%lx ", config_tables[i].table);
} else
if (efi_guidcmp(config_tables[i].guid, HCDP_TABLE_GUID) == 0) {
--
Matthew Garrett | mjg59@srcf.ucam.org
next reply other threads:[~2006-03-04 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-04 18:00 Matthew Garrett [this message]
2006-03-04 18:04 ` [PATCH] Remove __init from efi_get_time Matthew Garrett
2006-03-04 19:00 ` [PATCH] /sys/firmware/efi/systab giving incorrect value for smbios Matthew Garrett
2006-03-04 19:04 ` [Mactel-linux-devel] " gimli
2006-03-04 19:17 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2006-03-09 22:19 Tolentino, Matthew E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060304180018.GA3695@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mactel-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox