* emu10k1_synth use after free
@ 2006-03-06 8:53 Dave Jones
2006-03-06 13:50 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2006-03-06 8:53 UTC (permalink / raw)
To: Linux Kernel; +Cc: tiwai
Thou shalt not dereference freed memory.
Coverity bug #958
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/sound/pci/emu10k1/emu10k1_synth.c~ 2006-03-06 03:51:26.000000000 -0500
+++ linux-2.6/sound/pci/emu10k1/emu10k1_synth.c 2006-03-06 03:51:36.000000000 -0500
@@ -62,7 +62,6 @@ static int snd_emu10k1_synth_new_device(
if (snd_emux_register(emu, dev->card, arg->index, "Emu10k1") < 0) {
snd_emux_free(emu);
- emu->hw = NULL;
return -ENOMEM;
}
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: emu10k1_synth use after free
2006-03-06 8:53 emu10k1_synth use after free Dave Jones
@ 2006-03-06 13:50 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2006-03-06 13:50 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel
At Mon, 6 Mar 2006 03:53:17 -0500,
Dave Jones wrote:
>
> Thou shalt not dereference freed memory.
>
> Coverity bug #958
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/sound/pci/emu10k1/emu10k1_synth.c~ 2006-03-06 03:51:26.000000000 -0500
> +++ linux-2.6/sound/pci/emu10k1/emu10k1_synth.c 2006-03-06 03:51:36.000000000 -0500
> @@ -62,7 +62,6 @@ static int snd_emu10k1_synth_new_device(
>
> if (snd_emux_register(emu, dev->card, arg->index, "Emu10k1") < 0) {
> snd_emux_free(emu);
> - emu->hw = NULL;
> return -ENOMEM;
> }
>
>
Thanks, I applied it to ALSA tree, too.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-06 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-06 8:53 emu10k1_synth use after free Dave Jones
2006-03-06 13:50 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox