public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jesper.juhl@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: initcall at ... returned with error code -19 (Was: Re: 2.6.16-rc5-mm2)
Date: Mon, 6 Mar 2006 17:09:19 -0800	[thread overview]
Message-ID: <20060306170919.0fcd8566.pj@sgi.com> (raw)
In-Reply-To: <20060306140851.4140ae2b.akpm@osdl.org>

Andrew wrote:
> That's OK - it's -ENODEV. 

I can't help but wonder if the particular case of -ENODEV should
be kept quiet, as in the following totally untested patch:

diff -Naurp 2.6.16-rc5-mm2.orig/init/main.c 2.6.16-rc5-mm2/init/main.c
--- 2.6.16-rc5-mm2.orig/init/main.c	2006-03-06 17:02:46.491860190 -0800
+++ 2.6.16-rc5-mm2/init/main.c	2006-03-06 17:07:29.754830844 -0800
@@ -608,7 +608,8 @@ static void __init do_initcalls(void)
 
 		result = (*call)();
 
-		if (result) {
+		/* don't mind -ENODEV - just a driver w/o hardware */
+		if (result && result != -ENODEV) {
 			sprintf(msgbuf, "error code %d", result);
 			msg = msgbuf;
 		}

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

  parent reply	other threads:[~2006-03-07  1:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-06 21:59 initcall at ... returned with error code -19 (Was: Re: 2.6.16-rc5-mm2) Jesper Juhl
2006-03-06 22:08 ` Andrew Morton
2006-03-06 22:13   ` Jesper Juhl
2006-03-07  1:09   ` Paul Jackson [this message]
2006-03-07 13:10     ` Jes Sorensen
2006-03-07 17:31       ` Bjorn Helgaas
2006-03-07 17:30         ` Jes Sorensen
2006-03-06 22:16 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060306170919.0fcd8566.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox