From: Sam Ravnborg <sam@ravnborg.org>
To: "Paul D. Smith" <psmith@gnu.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] change kbuild to not rely on incorrect GNU make behavior
Date: Mon, 6 Mar 2006 21:45:17 +0100 [thread overview]
Message-ID: <20060306204517.GA29092@mars.ravnborg.org> (raw)
In-Reply-To: <17419.34083.172540.639486@lemming.engeast.baynetworks.com>
On Sun, Mar 05, 2006 at 07:41:07PM -0500, Paul D. Smith wrote:
> %% Sam Ravnborg <sam@ravnborg.org> writes:
>
> sr> Thanks Paul.
> sr> Adapted to -rc4 and applied to my kbuild tree which I have pushed out.
> sr> For reference I added the applied patch below.
>
> OK. Note that this:
>
> sr> -.PHONY: tar%pkg
> sr> +PHONY += tar%pkg
> sr> tar%pkg:
>
> won't do what you expect. tar%pkg is a pattern rule, but .PHONY doesn't
> take patterns so you're declaring the actual file named literally
> 'tar%pkg' to be phony.
So I can just let all relevant target rules include FORCE as
prerequisite and skip the PHONY part all together.
Thats what FORCE is there for anyway so this is just normal kbuild style
anyway.
Sam
next prev parent reply other threads:[~2006-03-06 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-05 22:14 [PATCH] change kbuild to not rely on incorrect GNU make behavior Paul Smith
2006-03-05 23:13 ` Sam Ravnborg
2006-03-06 0:41 ` Paul D. Smith
2006-03-06 9:41 ` Jan-Benedict Glaw
2006-03-06 20:45 ` Sam Ravnborg [this message]
2006-03-29 13:15 ` Arthur Othieno
2006-03-29 13:32 ` Paul D. Smith
2006-03-29 16:48 ` [stable] " Greg KH
2006-03-29 13:39 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060306204517.GA29092@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psmith@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox