Re: [PATCH] EDAC: core EDAC support code

Arjan van de Ven
2006-03-10T11:40:43Z

On Fri, 2006-03-10 at 11:06 +0000, Tim Small wrote:
> Arjan van de Ven wrote:
>
> > It depends on how many PCI devices in your machine you wish to
> >
> >>blacklist or whitelist. The motivation for this feature is that
> >>certain known badly-designed devices report an endless stream of
> >>spurious PCI bus parity errors. We want to skip such devices when
> >>checking for PCI bus parity errors.
> >>
> >>
> >
> >ok so this is actually a per pci device property!
> >I would suggest moving this property to the pci device itself, not doing
> >it inside an edac directory.
> >
> >
> Yes, this seems more sensible to me. For one thing, I suspect that just
> keying on vendor:device is probably too blunt for this and that
> blacklisting a particular PCI device revision is a likely requirement,
> as well as subsystem vendor/subsystem device.

and maybe even something as funky as firmware version.
So it for sure is a per device (not per ID) property, and something that
needs a global quirk table kind of thing with the option to do per
driver overrides