From: Benjamin LaHaise <bcrl@kvack.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>,
Chuck Ebbert <76306.1226@compuserve.com>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [patch] i386 spinlocks: disable interrupts only if we enabled them
Date: Tue, 7 Mar 2006 21:52:27 -0500 [thread overview]
Message-ID: <20060308025227.GP5410@kvack.org> (raw)
In-Reply-To: <20060308004308.GA16069@elte.hu>
On Wed, Mar 08, 2006 at 01:43:08AM +0100, Ingo Molnar wrote:
> we dont inline that code anymore. So i think the optimization is fine.
Why is that? It adds memory traffic that has to be synchronized
before the lock occurs and clobbered registers now in the caller.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-03-08 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-07 23:34 [patch] i386 spinlocks: disable interrupts only if we enabled them Chuck Ebbert
2006-03-08 0:15 ` Andrew Morton
2006-03-08 0:43 ` Ingo Molnar
2006-03-08 2:52 ` Benjamin LaHaise [this message]
2006-03-08 6:55 ` Andrew Morton
2006-03-08 8:52 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2006-03-08 1:45 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060308025227.GP5410@kvack.org \
--to=bcrl@kvack.org \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox