public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Latchesar Ionkov <lucho@ionkov.net>
Cc: linux-kernel@vger.kernel.org, ericvh@ericvh.myip.org
Subject: [-mm patch] add a prototype for v9fs_printfcall()
Date: Wed, 8 Mar 2006 10:08:27 +0100	[thread overview]
Message-ID: <20060308090827.GA4006@stusta.de> (raw)
In-Reply-To: <20060307021929.754329c9.akpm@osdl.org>

On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc3-mm2:
>...
> +v9fs-print-9p-messages.patch
>...
>  Misc updates and fixes
>...

If you create a function in one file and call them from another file you 
need a prototype in a header file or bad runtime errors can occur in 
some cases.

You mustn't ignore warnings about implicitely defined functions.
This bug was found by the gcc -Werror-implicit-function-declaration flag 
that turns such warnings into errors.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.16-rc5-mm3-full/fs/9p/9p.h.old	2006-03-07 13:31:13.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/fs/9p/9p.h	2006-03-07 13:32:08.000000000 +0100
@@ -372,3 +372,6 @@
 int v9fs_t_write(struct v9fs_session_info *v9ses, u32 fid, u64 offset,
 		 u32 count, const char __user * data,
 		 struct v9fs_fcall **rcall);
+
+int v9fs_printfcall(char *buf, int buflen, struct v9fs_fcall *fc, int extended);
+


  parent reply	other threads:[~2006-03-08  9:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 11:22 ` 2.6.16-rc5-mm3 Christoph Hellwig
2006-03-07 11:23   ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-10  9:44     ` 2.6.16-rc5-mm3 Christoph Hellwig
2006-03-07 20:37 ` 2.6.16-rc5-mm3 Martin Bligh
2006-03-07 20:39   ` 2.6.16-rc5-mm3 Martin Bligh
2006-03-07 20:51     ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 21:01       ` 2.6.16-rc5-mm3 Christoph Lameter
2006-03-07 21:21         ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-09 15:03       ` 2.6.16-rc5-mm3 Martin J. Bligh
2006-03-07 21:22 ` 2.6.16-rc5-mm3 Jesper Juhl
2006-03-07 22:17 ` 2.6.16-rc5-mm3 Valdis.Kletnieks
2006-03-07 22:30   ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 22:39     ` 2.6.16-rc5-mm3 Jun'ichi Nomura
2006-03-08  1:53 ` 2.6.16-rc5-mm3 Grant Coady
2006-03-08  9:08 ` Adrian Bunk [this message]
2006-03-08 11:30 ` 2.6.16-rc5-mm3: Why did dlm_lockres_master_requery() become global? Adrian Bunk
2006-03-08 11:34 ` [-mm patch] fs/9p/fcprint.c: make 2 functions static Adrian Bunk
2006-03-09  2:30 ` 2.6.16-rc5-mm3 Matthias Urlichs
2006-03-09  6:15 ` 2.6.16-rc5-mm3 Benoit Boissinot
     [not found]   ` <20060309144451.GA24034@ens-lyon.fr>
2006-03-09 15:11     ` 2.6.16-rc5-mm3 Benoit Boissinot
2006-03-11 15:20 ` ata2: dev 0 failed to IDENTIFY (I/O error) [Was: 2.6.16-rc5-mm3] Jiri Slaby
2006-03-11 15:57   ` [PATCH] libata: fix missing classes[] initialization in ata_bus_probe() Tejun Heo
2006-03-12  0:05     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060308090827.GA4006@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=ericvh@ericvh.myip.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox