* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
@ 2006-03-07 11:22 ` Christoph Hellwig
2006-03-07 11:23 ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 20:37 ` 2.6.16-rc5-mm3 Martin Bligh
` (9 subsequent siblings)
10 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2006-03-07 11:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
> +ia64-dont-report-sn2-or-summit-hardware-as-an-error.patch
> +sgi-sn-drivers-dont-report-sn2-hardware-as-an-error.patch
>
> ia64 fixes
These are wrong. The hardware is not available so -ENODEV is the right
return value. Especially in the mmtimer case this is a real bug because
the module would stay loaded despite not beeing initialized and uneeded,
in the others it's just cosmetical but still wrong.
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 11:22 ` 2.6.16-rc5-mm3 Christoph Hellwig
@ 2006-03-07 11:23 ` Andrew Morton
2006-03-10 9:44 ` 2.6.16-rc5-mm3 Christoph Hellwig
0 siblings, 1 reply; 24+ messages in thread
From: Andrew Morton @ 2006-03-07 11:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel
Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
> > +ia64-dont-report-sn2-or-summit-hardware-as-an-error.patch
> > +sgi-sn-drivers-dont-report-sn2-hardware-as-an-error.patch
> >
> > ia64 fixes
>
> These are wrong. The hardware is not available so -ENODEV is the right
> return value. Especially in the mmtimer case this is a real bug because
> the module would stay loaded despite not beeing initialized and uneeded,
> in the others it's just cosmetical but still wrong.
OK, thanks, gone.
I changed that initcall warning so it doesn't warn about -ENODEV unless you
specified initcall_debug.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 11:23 ` 2.6.16-rc5-mm3 Andrew Morton
@ 2006-03-10 9:44 ` Christoph Hellwig
0 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2006-03-10 9:44 UTC (permalink / raw)
To: Andrew Morton; +Cc: Christoph Hellwig, linux-kernel
On Tue, Mar 07, 2006 at 03:23:30AM -0800, Andrew Morton wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
> > > +ia64-dont-report-sn2-or-summit-hardware-as-an-error.patch
> > > +sgi-sn-drivers-dont-report-sn2-hardware-as-an-error.patch
> > >
> > > ia64 fixes
> >
> > These are wrong. The hardware is not available so -ENODEV is the right
> > return value. Especially in the mmtimer case this is a real bug because
> > the module would stay loaded despite not beeing initialized and uneeded,
> > in the others it's just cosmetical but still wrong.
>
> OK, thanks, gone.
The patches went into mainline anyway yesterday..
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 11:22 ` 2.6.16-rc5-mm3 Christoph Hellwig
@ 2006-03-07 20:37 ` Martin Bligh
2006-03-07 20:39 ` 2.6.16-rc5-mm3 Martin Bligh
2006-03-07 21:22 ` 2.6.16-rc5-mm3 Jesper Juhl
` (8 subsequent siblings)
10 siblings, 1 reply; 24+ messages in thread
From: Martin Bligh @ 2006-03-07 20:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
>
> - A relatively small number of changes, although we're up to 9MB of diff
> in the various git trees.
E_NOT_COMPILING ;-) i386+NUMA at least
NUMA-Q +
http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/numaq
=
http://test.kernel.org/24793/debug/test.log.0
mm/built-in.o(.text+0x178dc): In function `check_huge_range':
mm/mempolicy.c:1832: undefined reference to `huge_pte_offset'
make: *** [.tmp_vmlinux1] Error 1
03/07/06-12:25:56 Build the kernel. Failed rc = 2
03/07/06-12:25:56 build: kernel build Failed rc = 1
03/07/06-12:25:56 command complete: (2) rc=126
Much the same error on x440 +
http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/elm3b67
=
http://test.kernel.org/24791/debug/test.log.0
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 20:37 ` 2.6.16-rc5-mm3 Martin Bligh
@ 2006-03-07 20:39 ` Martin Bligh
2006-03-07 20:51 ` 2.6.16-rc5-mm3 Andrew Morton
0 siblings, 1 reply; 24+ messages in thread
From: Martin Bligh @ 2006-03-07 20:39 UTC (permalink / raw)
To: Martin Bligh; +Cc: Andrew Morton, linux-kernel, Linus Torvalds
Martin Bligh wrote:
> Andrew Morton wrote:
>
>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
>>
>>
>> - A relatively small number of changes, although we're up to 9MB of diff
>> in the various git trees.
>
>
> E_NOT_COMPILING ;-) i386+NUMA at least
>
> NUMA-Q +
> http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/numaq
> =
> http://test.kernel.org/24793/debug/test.log.0
> mm/built-in.o(.text+0x178dc): In function `check_huge_range':
> mm/mempolicy.c:1832: undefined reference to `huge_pte_offset'
> make: *** [.tmp_vmlinux1] Error 1
> 03/07/06-12:25:56 Build the kernel. Failed rc = 2
> 03/07/06-12:25:56 build: kernel build Failed rc = 1
> 03/07/06-12:25:56 command complete: (2) rc=126
>
> Much the same error on x440 +
> http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/elm3b67
> =
> http://test.kernel.org/24791/debug/test.log.0
Oh, BTW ... I see that's also broken in -git9, but not -git8.
Presumably something didn't go via -mm for testing?
M.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 20:39 ` 2.6.16-rc5-mm3 Martin Bligh
@ 2006-03-07 20:51 ` Andrew Morton
2006-03-07 21:01 ` 2.6.16-rc5-mm3 Christoph Lameter
2006-03-09 15:03 ` 2.6.16-rc5-mm3 Martin J. Bligh
0 siblings, 2 replies; 24+ messages in thread
From: Andrew Morton @ 2006-03-07 20:51 UTC (permalink / raw)
To: Martin Bligh; +Cc: mbligh, linux-kernel, torvalds, Christoph Lameter
Martin Bligh <mbligh@mbligh.org> wrote:
>
> Martin Bligh wrote:
> > Andrew Morton wrote:
> >
> >> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
> >>
> >>
> >> - A relatively small number of changes, although we're up to 9MB of diff
> >> in the various git trees.
> >
> >
> > E_NOT_COMPILING ;-) i386+NUMA at least
> >
> > NUMA-Q +
> > http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/numaq
> > =
> > http://test.kernel.org/24793/debug/test.log.0
> > mm/built-in.o(.text+0x178dc): In function `check_huge_range':
> > mm/mempolicy.c:1832: undefined reference to `huge_pte_offset'
> > make: *** [.tmp_vmlinux1] Error 1
> > 03/07/06-12:25:56 Build the kernel. Failed rc = 2
> > 03/07/06-12:25:56 build: kernel build Failed rc = 1
> > 03/07/06-12:25:56 command complete: (2) rc=126
> >
> > Much the same error on x440 +
> > http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/elm3b67
> > =
> > http://test.kernel.org/24791/debug/test.log.0
>
> Oh, BTW ... I see that's also broken in -git9, but not -git8.
>
> Presumably something didn't go via -mm for testing?
>
No, it's just that we suck. The numa-maps update got squeezed in at the
last minute.
I guess we do it this way - there's still code in there which will call
check_huge_range(), but it's inside if (0) {}.
--- devel/mm/mempolicy.c~numa_maps-update-fix 2006-03-07 12:48:38.000000000 -0800
+++ devel-akpm/mm/mempolicy.c 2006-03-07 12:49:22.000000000 -0800
@@ -1789,6 +1789,7 @@ static void gather_stats(struct page *pa
cond_resched();
}
+#ifdef CONFIG_HUGETLB_PAGE
static void check_huge_range(struct vm_area_struct *vma,
unsigned long start, unsigned long end,
struct numa_maps *md)
@@ -1814,6 +1815,7 @@ static void check_huge_range(struct vm_a
gather_stats(page, md, pte_dirty(*ptep));
}
}
+#endif
int show_numa_map(struct seq_file *m, void *v)
{
_
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 20:51 ` 2.6.16-rc5-mm3 Andrew Morton
@ 2006-03-07 21:01 ` Christoph Lameter
2006-03-07 21:21 ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-09 15:03 ` 2.6.16-rc5-mm3 Martin J. Bligh
1 sibling, 1 reply; 24+ messages in thread
From: Christoph Lameter @ 2006-03-07 21:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: Martin Bligh, linux-kernel, torvalds
On Tue, 7 Mar 2006, Andrew Morton wrote:
> --- devel/mm/mempolicy.c~numa_maps-update-fix 2006-03-07 12:48:38.000000000 -0800
> +++ devel-akpm/mm/mempolicy.c 2006-03-07 12:49:22.000000000 -0800
> @@ -1789,6 +1789,7 @@ static void gather_stats(struct page *pa
> cond_resched();
> }
>
> +#ifdef CONFIG_HUGETLB_PAGE
> static void check_huge_range(struct vm_area_struct *vma,
> unsigned long start, unsigned long end,
> struct numa_maps *md)
> @@ -1814,6 +1815,7 @@ static void check_huge_range(struct vm_a
> gather_stats(page, md, pte_dirty(*ptep));
> }
> }
#else
....
{
}
?
> +#endif
>
> int show_numa_map(struct seq_file *m, void *v)
> {
> _
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 21:01 ` 2.6.16-rc5-mm3 Christoph Lameter
@ 2006-03-07 21:21 ` Andrew Morton
0 siblings, 0 replies; 24+ messages in thread
From: Andrew Morton @ 2006-03-07 21:21 UTC (permalink / raw)
To: Christoph Lameter; +Cc: mbligh, linux-kernel, torvalds
Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> On Tue, 7 Mar 2006, Andrew Morton wrote:
>
> > --- devel/mm/mempolicy.c~numa_maps-update-fix 2006-03-07 12:48:38.000000000 -0800
> > +++ devel-akpm/mm/mempolicy.c 2006-03-07 12:49:22.000000000 -0800
> > @@ -1789,6 +1789,7 @@ static void gather_stats(struct page *pa
> > cond_resched();
> > }
> >
> > +#ifdef CONFIG_HUGETLB_PAGE
> > static void check_huge_range(struct vm_area_struct *vma,
> > unsigned long start, unsigned long end,
> > struct numa_maps *md)
> > @@ -1814,6 +1815,7 @@ static void check_huge_range(struct vm_a
> > gather_stats(page, md, pte_dirty(*ptep));
> > }
> > }
> #else
> ....
>
> {
> }
>
> ?
Yeah, that won't be needed for a link, but it's needed to avoid a compile
warning.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 20:51 ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 21:01 ` 2.6.16-rc5-mm3 Christoph Lameter
@ 2006-03-09 15:03 ` Martin J. Bligh
1 sibling, 0 replies; 24+ messages in thread
From: Martin J. Bligh @ 2006-03-09 15:03 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, torvalds, Christoph Lameter
> No, it's just that we suck. The numa-maps update got squeezed in at the
> last minute.
>
> I guess we do it this way - there's still code in there which will call
> check_huge_range(), but it's inside if (0) {}.
Works as of -git12.
Thanks!
M.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
2006-03-07 11:22 ` 2.6.16-rc5-mm3 Christoph Hellwig
2006-03-07 20:37 ` 2.6.16-rc5-mm3 Martin Bligh
@ 2006-03-07 21:22 ` Jesper Juhl
2006-03-07 22:17 ` 2.6.16-rc5-mm3 Valdis.Kletnieks
` (7 subsequent siblings)
10 siblings, 0 replies; 24+ messages in thread
From: Jesper Juhl @ 2006-03-07 21:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On 3/7/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
>
Just for the record; the slab corruption I was seeing with
2.6.16-rc5-mm2 does not occour with this kernel.
After a lot of rebuilds and very good bug hunting by various people we
found the offensive patch and it seems you removed it from -mm -
thanks.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (2 preceding siblings ...)
2006-03-07 21:22 ` 2.6.16-rc5-mm3 Jesper Juhl
@ 2006-03-07 22:17 ` Valdis.Kletnieks
2006-03-07 22:30 ` 2.6.16-rc5-mm3 Andrew Morton
2006-03-08 1:53 ` 2.6.16-rc5-mm3 Grant Coady
` (6 subsequent siblings)
10 siblings, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2006-03-07 22:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]
On Tue, 07 Mar 2006 02:19:29 PST, Andrew Morton said:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
Seen during early boot from the initrd, while the initrd was firing up a
'lvm vgscan' to get the root filesystem accessible.. 2.6.15-rc5-mm2 didn't do this.
Dell laptop, Pentium4, UP kernel...
[ 16.959458] Freeing unused kernel memory: 176k freed
[ 16.984855] Write protecting the kernel read-only data: 998k
[ 17.044106] Time: tsc clocksource has been installed.
[ 17.600897] BUG: sleeping function called from invalid context at mm/slab.c:2751
[ 17.625891] in_atomic():1, irqs_disabled():0
[ 17.650461] [<c0103aba>] show_trace+0xd/0xf
[ 17.674759] [<c0103b5b>] dump_stack+0x17/0x19
[ 17.698533] [<c010ff3c>] __might_sleep+0x86/0x90
[ 17.722149] [<c015155a>] kmem_cache_alloc+0x27/0x82
[ 17.745520] [<c015baf1>] bd_claim_by_kobject+0x77/0x1b1
[ 17.768657] [<c02a55a4>] open_dev+0x54/0x72
[ 17.791983] [<c02a5c8b>] dm_get_device+0x13f/0x336
[ 17.815254] [<c02a656c>] linear_ctr+0x7f/0xbb
[ 17.838389] [<c02a5996>] dm_table_add_target+0x10e/0x233
[ 17.861491] [<c02a7c82>] table_load+0xc9/0x1a5
[ 17.884366] [<c02a796b>] ctl_ioctl+0x208/0x246
[ 17.906866] [<c01653f2>] do_ioctl+0x4e/0x67
[ 17.929035] [<c0165657>] vfs_ioctl+0x24c/0x25f
[ 17.950782] [<c01656b1>] sys_ioctl+0x47/0x62
[ 17.971931] [<c0102707>] syscall_call+0x7/0xb
[ 18.426629] kjournald starting. Commit interval 5 seconds
[-- Attachment #2: Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 22:17 ` 2.6.16-rc5-mm3 Valdis.Kletnieks
@ 2006-03-07 22:30 ` Andrew Morton
2006-03-07 22:39 ` 2.6.16-rc5-mm3 Jun'ichi Nomura
0 siblings, 1 reply; 24+ messages in thread
From: Andrew Morton @ 2006-03-07 22:30 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: linux-kernel, Jun'ichi Nomura
Valdis.Kletnieks@vt.edu wrote:
>
> On Tue, 07 Mar 2006 02:19:29 PST, Andrew Morton said:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
>
> Seen during early boot from the initrd, while the initrd was firing up a
> 'lvm vgscan' to get the root filesystem accessible.. 2.6.15-rc5-mm2 didn't do this.
> Dell laptop, Pentium4, UP kernel...
>
> [ 16.959458] Freeing unused kernel memory: 176k freed
> [ 16.984855] Write protecting the kernel read-only data: 998k
> [ 17.044106] Time: tsc clocksource has been installed.
> [ 17.600897] BUG: sleeping function called from invalid context at mm/slab.c:2751
> [ 17.625891] in_atomic():1, irqs_disabled():0
> [ 17.650461] [<c0103aba>] show_trace+0xd/0xf
> [ 17.674759] [<c0103b5b>] dump_stack+0x17/0x19
> [ 17.698533] [<c010ff3c>] __might_sleep+0x86/0x90
> [ 17.722149] [<c015155a>] kmem_cache_alloc+0x27/0x82
> [ 17.745520] [<c015baf1>] bd_claim_by_kobject+0x77/0x1b1
> [ 17.768657] [<c02a55a4>] open_dev+0x54/0x72
> [ 17.791983] [<c02a5c8b>] dm_get_device+0x13f/0x336
> [ 17.815254] [<c02a656c>] linear_ctr+0x7f/0xbb
> [ 17.838389] [<c02a5996>] dm_table_add_target+0x10e/0x233
> [ 17.861491] [<c02a7c82>] table_load+0xc9/0x1a5
> [ 17.884366] [<c02a796b>] ctl_ioctl+0x208/0x246
> [ 17.906866] [<c01653f2>] do_ioctl+0x4e/0x67
> [ 17.929035] [<c0165657>] vfs_ioctl+0x24c/0x25f
> [ 17.950782] [<c01656b1>] sys_ioctl+0x47/0x62
> [ 17.971931] [<c0102707>] syscall_call+0x7/0xb
> [ 18.426629] kjournald starting. Commit interval 5 seconds
>
Thanks. Those patches are being redone.
Jun'ishi-san, please ensure that they're tested with CONFIG_PREEMPT and all
debug options turned on.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 22:30 ` 2.6.16-rc5-mm3 Andrew Morton
@ 2006-03-07 22:39 ` Jun'ichi Nomura
0 siblings, 0 replies; 24+ messages in thread
From: Jun'ichi Nomura @ 2006-03-07 22:39 UTC (permalink / raw)
To: Andrew Morton; +Cc: Valdis.Kletnieks, linux-kernel
Andrew Morton wrote:
>>[ 17.600897] BUG: sleeping function called from invalid context at mm/slab.c:2751
>>[ 17.625891] in_atomic():1, irqs_disabled():0
>>[ 17.650461] [<c0103aba>] show_trace+0xd/0xf
>>[ 17.674759] [<c0103b5b>] dump_stack+0x17/0x19
>>[ 17.698533] [<c010ff3c>] __might_sleep+0x86/0x90
>>[ 17.722149] [<c015155a>] kmem_cache_alloc+0x27/0x82
>>[ 17.745520] [<c015baf1>] bd_claim_by_kobject+0x77/0x1b1
...
> Jun'ishi-san, please ensure that they're tested with CONFIG_PREEMPT and all
> debug options turned on.
Oops, thank you for testing and reporting.
I'll make sure to test with CONFIG_PREEMPT.
Thanks,
--
Jun'ichi Nomura, NEC Solutions (America), Inc.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (3 preceding siblings ...)
2006-03-07 22:17 ` 2.6.16-rc5-mm3 Valdis.Kletnieks
@ 2006-03-08 1:53 ` Grant Coady
2006-03-08 9:08 ` [-mm patch] add a prototype for v9fs_printfcall() Adrian Bunk
` (5 subsequent siblings)
10 siblings, 0 replies; 24+ messages in thread
From: Grant Coady @ 2006-03-08 1:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Tue, 7 Mar 2006 02:19:29 -0800, Andrew Morton <akpm@osdl.org> wrote:
>
>ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
>
>- A relatively small number of changes, although we're up to 9MB of diff
> in the various git trees.
Hi there,
-mm3 failed to boot on sempro box[1], after lilo, screen went blank,
no response... hit reset to reboot... Same config as -mm2 which did
boot okay.
Applying "revert-x86_64-mm-i386-early-alignment.patch" fixed it here too.
(CPU is Sempron SktA 32-bit)
[1] http://bugsplatter.mine.nu/test/linux-2.6/sempro/ for dmesg & config
from -mm2
Grant.
^ permalink raw reply [flat|nested] 24+ messages in thread* [-mm patch] add a prototype for v9fs_printfcall()
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (4 preceding siblings ...)
2006-03-08 1:53 ` 2.6.16-rc5-mm3 Grant Coady
@ 2006-03-08 9:08 ` Adrian Bunk
2006-03-08 11:30 ` 2.6.16-rc5-mm3: Why did dlm_lockres_master_requery() become global? Adrian Bunk
` (4 subsequent siblings)
10 siblings, 0 replies; 24+ messages in thread
From: Adrian Bunk @ 2006-03-08 9:08 UTC (permalink / raw)
To: Andrew Morton, Latchesar Ionkov; +Cc: linux-kernel, ericvh
On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc3-mm2:
>...
> +v9fs-print-9p-messages.patch
>...
> Misc updates and fixes
>...
If you create a function in one file and call them from another file you
need a prototype in a header file or bad runtime errors can occur in
some cases.
You mustn't ignore warnings about implicitely defined functions.
This bug was found by the gcc -Werror-implicit-function-declaration flag
that turns such warnings into errors.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc5-mm3-full/fs/9p/9p.h.old 2006-03-07 13:31:13.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/fs/9p/9p.h 2006-03-07 13:32:08.000000000 +0100
@@ -372,3 +372,6 @@
int v9fs_t_write(struct v9fs_session_info *v9ses, u32 fid, u64 offset,
u32 count, const char __user * data,
struct v9fs_fcall **rcall);
+
+int v9fs_printfcall(char *buf, int buflen, struct v9fs_fcall *fc, int extended);
+
^ permalink raw reply [flat|nested] 24+ messages in thread* 2.6.16-rc5-mm3: Why did dlm_lockres_master_requery() become global?
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (5 preceding siblings ...)
2006-03-08 9:08 ` [-mm patch] add a prototype for v9fs_printfcall() Adrian Bunk
@ 2006-03-08 11:30 ` Adrian Bunk
2006-03-08 11:34 ` [-mm patch] fs/9p/fcprint.c: make 2 functions static Adrian Bunk
` (3 subsequent siblings)
10 siblings, 0 replies; 24+ messages in thread
From: Adrian Bunk @ 2006-03-08 11:30 UTC (permalink / raw)
To: Andrew Morton, mark.fasheh, kurt.hackel; +Cc: linux-kernel, ocfs2-devel
On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc3-mm2:
>...
> git-ocfs2.patch
>...
> git trees
>...
Why did dlm_lockres_master_requery() become global?
It is neither used in another file nor does any of the changeset
descriptions escribe it.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 24+ messages in thread* [-mm patch] fs/9p/fcprint.c: make 2 functions static
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (6 preceding siblings ...)
2006-03-08 11:30 ` 2.6.16-rc5-mm3: Why did dlm_lockres_master_requery() become global? Adrian Bunk
@ 2006-03-08 11:34 ` Adrian Bunk
2006-03-09 2:30 ` 2.6.16-rc5-mm3 Matthias Urlichs
` (2 subsequent siblings)
10 siblings, 0 replies; 24+ messages in thread
From: Adrian Bunk @ 2006-03-08 11:34 UTC (permalink / raw)
To: Andrew Morton, Latchesar Ionkov; +Cc: linux-kernel, ericvh
On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc3-mm2:
>...
> +v9fs-print-9p-messages.patch
>...
> Misc updates and fixes
>...
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/9p/fcprint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.16-rc5-mm3-full/fs/9p/fcprint.c.old 2006-03-08 12:31:26.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/fs/9p/fcprint.c 2006-03-08 12:31:49.000000000 +0100
@@ -88,7 +88,7 @@
return snprintf(buf, buflen, "%s%03o", b, perm&077);
}
-int
+static int
v9fs_printstat(char *buf, int buflen, struct v9fs_stat *st, int extended)
{
int n;
@@ -120,7 +120,7 @@
return n;
}
-int
+static int
v9fs_dumpdata(char *buf, int buflen, u8 *data, int datalen)
{
int i, n;
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (7 preceding siblings ...)
2006-03-08 11:34 ` [-mm patch] fs/9p/fcprint.c: make 2 functions static Adrian Bunk
@ 2006-03-09 2:30 ` Matthias Urlichs
2006-03-09 6:15 ` 2.6.16-rc5-mm3 Benoit Boissinot
2006-03-11 15:20 ` ata2: dev 0 failed to IDENTIFY (I/O error) [Was: 2.6.16-rc5-mm3] Jiri Slaby
10 siblings, 0 replies; 24+ messages in thread
From: Matthias Urlichs @ 2006-03-09 2:30 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-kernel-announce
Hi, Andrew Morton wrote:
> - To fetch an -mm tree using git, use (for example)
>
> git fetch git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git v2.6.16-rc2-mm1
The importer hit a snag and didn't get the last three -mm kernels or so.
Should fix itself during the next few hours.
Please tell me directly if there's a problem; usually, new -mm releases
should be available as git trees 2h after an announcement.
--
Matthias Urlichs
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc5-mm3
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (8 preceding siblings ...)
2006-03-09 2:30 ` 2.6.16-rc5-mm3 Matthias Urlichs
@ 2006-03-09 6:15 ` Benoit Boissinot
[not found] ` <20060309144451.GA24034@ens-lyon.fr>
2006-03-11 15:20 ` ata2: dev 0 failed to IDENTIFY (I/O error) [Was: 2.6.16-rc5-mm3] Jiri Slaby
10 siblings, 1 reply; 24+ messages in thread
From: Benoit Boissinot @ 2006-03-09 6:15 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc5/2.6.16-rc5-mm3/
>
> - A relatively small number of changes, although we're up to 9MB of diff
> in the various git trees.
>
I just encountered a memleak, this is a laptop and i use swsusp (I am not
sure if it is related but since the memleak involves task_struct).
Let me know if you need any other informations, i'll see if it is
reproducable in the next days.
regards.
Benoit
procs -----------memory---------- ---swap-- -----io---- --system-- ----cpu----
r b swpd free buff cache si so bi bo in cs us sy id wa
0 0 0 35176 25148 69532 6 4 42 72 44 332 12 2 83 3
total used free shared buffers cached
Mem: 515256 479648 35608 0 24860 69504
-/+ buffers/cache: 385284 129972
Swap: 979956 0 979956
slabinfo - version: 2.1
# name <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> : slabdata <active_slabs> <num_slabs> <sharedavail> : shrinker stat <nr requested> <nr freed>
ip_conntrack_expect 0 0 92 42 1 : tunables 120 60 0 : slabdata 0 0 0
ip_conntrack 19 38 208 19 1 : tunables 120 60 0 : slabdata 2 2 0
ip_fib_alias 10 113 32 113 1 : tunables 120 60 0 : slabdata 1 1 0
ip_fib_hash 10 113 32 113 1 : tunables 120 60 0 : slabdata 1 1 0
uhci_urb_priv 0 0 28 127 1 : tunables 120 60 0 : slabdata 0 0 0
UNIX 40 40 384 10 1 : tunables 54 27 0 : slabdata 4 4 0
tcp_bind_bucket 6 203 16 203 1 : tunables 120 60 0 : slabdata 1 1 0
inet_peer_cache 0 0 64 59 1 : tunables 120 60 0 : slabdata 0 0 0
secpath_cache 0 0 128 30 1 : tunables 120 60 0 : slabdata 0 0 0
xfrm_dst_cache 0 0 288 13 1 : tunables 54 27 0 : slabdata 0 0 0
ip_dst_cache 65 75 256 15 1 : tunables 120 60 0 : slabdata 5 5 0
arp_cache 2 30 128 30 1 : tunables 120 60 0 : slabdata 1 1 0
RAW 2 9 448 9 1 : tunables 54 27 0 : slabdata 1 1 0
UDP 1 9 448 9 1 : tunables 54 27 0 : slabdata 1 1 0
tw_sock_TCP 0 0 96 40 1 : tunables 120 60 0 : slabdata 0 0 0
request_sock_TCP 0 0 64 59 1 : tunables 120 60 0 : slabdata 0 0 0
TCP 6 21 1056 7 2 : tunables 24 12 0 : slabdata 3 3 0
flow_cache 0 0 96 40 1 : tunables 120 60 0 : slabdata 0 0 0
cfq_ioc_pool 35 100 76 50 1 : tunables 120 60 0 : slabdata 2 2 0
cfq_pool 36 78 100 39 1 : tunables 120 60 0 : slabdata 2 2 0
crq_pool 59 168 44 84 1 : tunables 120 60 0 : slabdata 2 2 0
deadline_drq 0 0 48 78 1 : tunables 120 60 0 : slabdata 0 0 0
as_arq 0 0 60 63 1 : tunables 120 60 0 : slabdata 0 0 0
mqueue_inode_cache 1 7 544 7 1 : tunables 54 27 0 : slabdata 1 1 0
isofs_inode_cache 0 0 384 10 1 : tunables 54 27 0 : slabdata 0 0 0
ext2_inode_cache 0 0 484 8 1 : tunables 54 27 0 : slabdata 0 0 0
ext2_xattr 0 0 44 84 1 : tunables 120 60 0 : slabdata 0 0 0 : shrinker stat 0 0
journal_handle 0 0 20 169 1 : tunables 120 60 0 : slabdata 0 0 0
journal_head 0 0 52 72 1 : tunables 120 60 0 : slabdata 0 0 0
revoke_table 2 254 12 254 1 : tunables 120 60 0 : slabdata 1 1 0
revoke_record 0 0 16 203 1 : tunables 120 60 0 : slabdata 0 0 0
ext3_inode_cache 2 7 524 7 1 : tunables 54 27 0 : slabdata 1 1 0
ext3_xattr 0 0 44 84 1 : tunables 120 60 0 : slabdata 0 0 0 : shrinker stat 0 0
reiser_inode_cache 4509 4536 432 9 1 : tunables 54 27 0 : slabdata 504 504 0
dnotify_cache 0 0 20 169 1 : tunables 120 60 0 : slabdata 0 0 0
eventpoll_pwq 0 0 36 101 1 : tunables 120 60 0 : slabdata 0 0 0
eventpoll_epi 0 0 96 40 1 : tunables 120 60 0 : slabdata 0 0 0
inotify_event_cache 0 0 28 127 1 : tunables 120 60 0 : slabdata 0 0 0
inotify_watch_cache 1 101 36 101 1 : tunables 120 60 0 : slabdata 1 1 0
kioctx 0 0 160 24 1 : tunables 120 60 0 : slabdata 0 0 0
kiocb 0 0 128 30 1 : tunables 120 60 0 : slabdata 0 0 0
fasync_cache 1 203 16 203 1 : tunables 120 60 0 : slabdata 1 1 0
shmem_inode_cache 814 819 448 9 1 : tunables 54 27 0 : slabdata 91 91 0
swapped_entry 0 0 12 254 1 : tunables 120 60 0 : slabdata 0 0 0
posix_timers_cache 0 0 96 40 1 : tunables 120 60 0 : slabdata 0 0 0
uid_cache 2 59 64 59 1 : tunables 120 60 0 : slabdata 1 1 0
sgpool-128 32 32 2048 2 1 : tunables 24 12 0 : slabdata 16 16 0
sgpool-64 32 32 1024 4 1 : tunables 54 27 0 : slabdata 8 8 0
sgpool-32 32 32 512 8 1 : tunables 54 27 0 : slabdata 4 4 0
sgpool-16 32 45 256 15 1 : tunables 120 60 0 : slabdata 3 3 0
sgpool-8 32 60 128 30 1 : tunables 120 60 0 : slabdata 2 2 0
scsi_io_context 0 0 104 37 1 : tunables 120 60 0 : slabdata 0 0 0
blkdev_ioc 35 127 28 127 1 : tunables 120 60 0 : slabdata 1 1 0
blkdev_queue 27 28 904 4 1 : tunables 54 27 0 : slabdata 7 7 0
blkdev_requests 46 46 168 23 1 : tunables 120 60 0 : slabdata 2 2 0
biovec-(256) 7 8 3072 2 2 : tunables 24 12 0 : slabdata 4 4 0
biovec-128 7 10 1536 5 2 : tunables 24 12 0 : slabdata 2 2 0
biovec-64 7 10 768 5 1 : tunables 54 27 0 : slabdata 2 2 0
biovec-16 7 20 192 20 1 : tunables 120 60 0 : slabdata 1 1 0
biovec-4 7 59 64 59 1 : tunables 120 60 0 : slabdata 1 1 0
biovec-1 54 203 16 203 1 : tunables 120 60 0 : slabdata 1 1 0
bio 303 354 64 59 1 : tunables 120 60 0 : slabdata 6 6 0
sock_inode_cache 90 90 416 9 1 : tunables 54 27 0 : slabdata 10 10 0
skbuff_fclone_cache 0 0 352 11 1 : tunables 54 27 0 : slabdata 0 0 0
skbuff_head_cache 128 240 192 20 1 : tunables 120 60 0 : slabdata 12 12 0
file_lock_cache 18 42 92 42 1 : tunables 120 60 0 : slabdata 1 1 0
acpi_operand 741 828 40 92 1 : tunables 120 60 0 : slabdata 9 9 0
acpi_parse_ext 0 0 44 84 1 : tunables 120 60 0 : slabdata 0 0 0
acpi_parse 0 0 28 127 1 : tunables 120 60 0 : slabdata 0 0 0
acpi_state 0 0 48 78 1 : tunables 120 60 0 : slabdata 0 0 0
proc_inode_cache 245 300 372 10 1 : tunables 54 27 0 : slabdata 30 30 0
sigqueue 4 27 144 27 1 : tunables 120 60 0 : slabdata 1 1 0
radix_tree_node 3012 3276 276 14 1 : tunables 54 27 0 : slabdata 234 234 0
bdev_cache 7 14 512 7 1 : tunables 54 27 0 : slabdata 2 2 0
sysfs_dir_cache 4727 4784 40 92 1 : tunables 120 60 0 : slabdata 52 52 0
mnt_cache 22 30 128 30 1 : tunables 120 60 0 : slabdata 1 1 0
inode_cache 1239 1287 356 11 1 : tunables 54 27 0 : slabdata 117 117 0 : shrinker stat 2043264 2047000
dentry_cache 10770 10770 128 30 1 : tunables 120 60 0 : slabdata 359 359 0 : shrinker stat 4719104 2255900
filp 740 900 192 20 1 : tunables 120 60 0 : slabdata 45 45 0
names_cache 5 5 4096 1 1 : tunables 24 12 0 : slabdata 5 5 0
idr_layer_cache 92 116 136 29 1 : tunables 120 60 0 : slabdata 4 4 0
buffer_head 6006 6006 48 78 1 : tunables 120 60 0 : slabdata 77 77 0
mm_struct 63 63 448 9 1 : tunables 54 27 0 : slabdata 7 7 0
vm_area_struct 1448 1496 88 44 1 : tunables 120 60 0 : slabdata 34 34 0
fs_cache 83 113 32 113 1 : tunables 120 60 0 : slabdata 1 1 0
files_cache 84 120 192 20 1 : tunables 120 60 0 : slabdata 6 6 0
signal_cache 84 90 384 10 1 : tunables 54 27 0 : slabdata 9 9 0
sighand_cache 57 57 1344 3 1 : tunables 24 12 0 : slabdata 19 19 0
task_struct 60291 60291 1344 3 1 : tunables 24 12 0 : slabdata 20097 20097 0
anon_vma 750 1356 8 339 1 : tunables 120 60 0 : slabdata 4 4 0
pgd 41 41 4096 1 1 : tunables 24 12 0 : slabdata 41 41 0
size-131072(DMA) 0 0 131072 1 32 : tunables 8 4 0 : slabdata 0 0 0
size-131072 0 0 131072 1 32 : tunables 8 4 0 : slabdata 0 0 0
size-65536(DMA) 0 0 65536 1 16 : tunables 8 4 0 : slabdata 0 0 0
size-65536 4 4 65536 1 16 : tunables 8 4 0 : slabdata 4 4 0
size-32768(DMA) 0 0 32768 1 8 : tunables 8 4 0 : slabdata 0 0 0
size-32768 1 1 32768 1 8 : tunables 8 4 0 : slabdata 1 1 0
size-16384(DMA) 0 0 16384 1 4 : tunables 8 4 0 : slabdata 0 0 0
size-16384 25 25 16384 1 4 : tunables 8 4 0 : slabdata 25 25 0
size-8192(DMA) 0 0 8192 1 2 : tunables 8 4 0 : slabdata 0 0 0
size-8192 6 6 8192 1 2 : tunables 8 4 0 : slabdata 6 6 0
size-4096(DMA) 0 0 4096 1 1 : tunables 24 12 0 : slabdata 0 0 0
size-4096 60463 60476 4096 1 1 : tunables 24 12 0 : slabdata 60463 60476 0
size-2048(DMA) 0 0 2048 2 1 : tunables 24 12 0 : slabdata 0 0 0
size-2048 47 48 2048 2 1 : tunables 24 12 0 : slabdata 24 24 0
size-1024(DMA) 0 0 1024 4 1 : tunables 54 27 0 : slabdata 0 0 0
size-1024 180 180 1024 4 1 : tunables 54 27 0 : slabdata 45 45 0
size-512(DMA) 0 0 512 8 1 : tunables 54 27 0 : slabdata 0 0 0
size-512 262 272 512 8 1 : tunables 54 27 0 : slabdata 34 34 0
size-256(DMA) 0 0 256 15 1 : tunables 120 60 0 : slabdata 0 0 0
size-256 71 75 256 15 1 : tunables 120 60 0 : slabdata 5 5 0
size-192(DMA) 0 0 192 20 1 : tunables 120 60 0 : slabdata 0 0 0
size-192 840 840 192 20 1 : tunables 120 60 0 : slabdata 42 42 0
size-128(DMA) 0 0 128 30 1 : tunables 120 60 0 : slabdata 0 0 0
size-128 932 1080 128 30 1 : tunables 120 60 0 : slabdata 36 36 0
size-64(DMA) 0 0 64 59 1 : tunables 120 60 0 : slabdata 0 0 0
size-32(DMA) 0 0 32 113 1 : tunables 120 60 0 : slabdata 0 0 0
size-64 1389 1711 64 59 1 : tunables 120 60 0 : slabdata 29 29 0
size-32 63413 64636 32 113 1 : tunables 120 60 0 : slabdata 572 572 0
kmem_cache 119 120 128 30 1 : tunables 120 60 0 : slabdata 4 4 0
MemTotal: 515256 kB
MemFree: 39436 kB
Buffers: 21080 kB
Cached: 69492 kB
SwapCached: 0 kB
Active: 80392 kB
Inactive: 48388 kB
HighTotal: 0 kB
HighFree: 0 kB
LowTotal: 515256 kB
LowFree: 39436 kB
SwapTotal: 979956 kB
SwapFree: 979956 kB
Dirty: 16 kB
Writeback: 0 kB
Mapped: 59824 kB
Slab: 333300 kB
CommitLimit: 1237584 kB
Committed_AS: 106788 kB
PageTables: 572 kB
VmallocTotal: 515800 kB
VmallocUsed: 26684 kB
VmallocChunk: 487124 kB
ps aux:
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
root 1 0.0 0.0 1484 332 ? Ss Mar07 0:01 init [3]
root 2 0.0 0.0 0 0 ? SN Mar07 0:00 [ksoftirqd/0]
root 3 0.0 0.0 0 0 ? S Mar07 0:00 [watchdog/0]
root 4 0.0 0.0 0 0 ? S< Mar07 0:01 [events/0]
root 5 0.0 0.0 0 0 ? S< Mar07 0:00 [khelper]
root 6 0.0 0.0 0 0 ? S< Mar07 0:00 [kthread]
root 8 0.0 0.0 0 0 ? S< Mar07 0:00 [kblockd/0]
root 9 0.0 0.0 0 0 ? S< Mar07 0:00 [kacpid]
root 114 0.0 0.0 0 0 ? S< Mar07 0:00 [kseriod]
root 152 0.0 0.0 0 0 ? S Mar07 0:05 [kswapd0]
root 153 0.0 0.0 0 0 ? SN Mar07 0:00 [kprefetchd]
root 154 0.0 0.0 0 0 ? S< Mar07 0:00 [aio/0]
root 822 0.0 0.0 0 0 ? S< Mar07 0:00 [reiserfs/0]
root 1021 0.0 0.0 1692 348 ? S<s Mar07 0:00 /sbin/udevd --daemon
root 2268 0.0 0.0 0 0 ? S< Mar07 0:00 [kpsmoused]
root 2274 0.0 0.0 0 0 ? S< Mar07 0:13 [ipw2200/0]
root 2431 0.0 0.0 0 0 ? S< Mar07 0:00 [khubd]
root 2734 0.0 0.0 0 0 ? S< Mar07 0:00 [kjournald]
root 3283 0.0 0.0 1824 464 ? Ss Mar07 0:00 /usr/sbin/syslog-ng
root 3356 0.0 0.0 1596 276 ? Ss Mar07 0:00 /usr/sbin/acpid -c /etc/acpi/events
root 6696 0.0 0.0 3420 260 ? Ss Mar07 0:00 /usr/sbin/sshd
root 6766 0.0 0.0 1720 228 ? Ss Mar07 0:00 /usr/sbin/cron
root 6919 0.0 0.2 2280 1108 tty2 Ss Mar07 0:00 /bin/login --
root 6920 0.0 0.0 1516 84 tty3 Ss+ Mar07 0:00 /sbin/agetty 38400 tty3 linux
root 6921 0.0 0.0 1516 84 tty4 Ss+ Mar07 0:00 /sbin/agetty 38400 tty4 linux
root 6940 0.0 0.0 1512 80 tty5 Ss+ Mar07 0:00 /sbin/agetty 38400 tty5 linux
root 6943 0.0 0.0 1512 80 tty6 Ss+ Mar07 0:00 /sbin/agetty 38400 tty6 linux
tonfa 7292 0.0 0.0 3036 488 ? Ss Mar07 0:00 ssh-agent
root 5142 0.0 0.0 1940 128 ? Ss Mar07 0:00 rsync --daemon
root 10474 0.0 0.0 0 0 ? S Mar08 0:01 [pdflush]
root 18538 0.0 0.0 0 0 ? S 03:32 0:00 [pdflush]
root 14408 0.0 0.2 2280 1108 tty1 Ss 06:40 0:00 /bin/login --
root 14470 0.0 0.4 3256 2208 tty1 S 06:40 0:00 -bash
root 15495 0.0 0.1 3192 852 ? Ss 06:42 0:00 /sbin/wpa_supplicant -Dwext -c/etc/wpa_supplicant.conf -W -P/var/run/wpa_supplicant-wlan.pid -B -iwlan
root 15506 0.0 0.0 1928 404 ? Ss 06:42 0:00 /bin/wpa_cli -a/sbin/wpa_cli.action -iwlan -P/var/run/wpa_cli-wlan.pid -B
tonfa 15867 0.0 0.4 3776 2284 tty2 S 06:42 0:00 -bash
root 16137 0.0 0.1 3536 844 ? Ss 06:42 0:00 /usr/bin/xdm
root 16140 0.4 1.7 13996 9132 tty7 Ss+ 06:42 0:02 /usr/bin/X vt7 -nolisten tcp -auth /etc/X11/xdm/authdir/authfiles/A:0-08C0Mi
root 16141 0.0 0.4 4168 2224 ? S 06:42 0:00 -:0
tonfa 16150 0.0 0.3 3328 1664 tty2 S+ 06:42 0:00 ssh arakou.residence.ens
tonfa 16151 0.0 0.3 3484 1780 tty2 S+ 06:42 0:00 ssh -T XXX
tonfa 16167 0.0 0.2 2632 1220 ? S 06:44 0:00 /bin/bash /home/tonfa/.xsession
tonfa 16249 0.0 0.2 6276 1240 ? S 06:44 0:00 urxvtd
tonfa 16250 0.0 0.2 2896 1164 ? S 06:44 0:00 /bin/sh /home/tonfa/bin/wmii
tonfa 16253 0.0 0.2 2796 1312 ? S 06:44 0:00 wmiiwm -a unix /tmp/ns.tonfa.:0/wmii
tonfa 16276 0.3 0.2 3024 1228 ? S 06:44 0:01 /bin/sh /home/tonfa/local/etc/wmii-3/status
tonfa 16323 0.0 0.0 2492 500 ? S 06:44 0:00 wmiir read /event
tonfa 16324 0.0 0.1 3028 580 ? S 06:44 0:00 /bin/sh /home/tonfa/local/etc/wmii-3/wmiirc
tonfa 19037 0.0 0.2 3148 1352 ? S 06:45 0:00 /bin/bash /usr/libexec/mozilla-launcher
tonfa 19062 3.1 7.9 103516 41204 ? Sl 06:45 0:09 /usr/lib/mozilla-firefox/firefox-bin
tonfa 19090 0.0 0.4 3840 2252 ? S 06:45 0:00 /usr/libexec/gconfd-2 10
tonfa 21210 0.0 0.0 1720 512 ? S 06:50 0:00 sleep 1
root 21211 0.0 0.1 2228 880 tty1 R+ 06:50 0:00 ps aux
--
powered by bash/screen/(urxvt/fvwm|linux-console)/gentoo/gnu/linux OS
^ permalink raw reply [flat|nested] 24+ messages in thread* ata2: dev 0 failed to IDENTIFY (I/O error) [Was: 2.6.16-rc5-mm3]
2006-03-07 10:19 2.6.16-rc5-mm3 Andrew Morton
` (9 preceding siblings ...)
2006-03-09 6:15 ` 2.6.16-rc5-mm3 Benoit Boissinot
@ 2006-03-11 15:20 ` Jiri Slaby
2006-03-11 15:57 ` [PATCH] libata: fix missing classes[] initialization in ata_bus_probe() Tejun Heo
10 siblings, 1 reply; 24+ messages in thread
From: Jiri Slaby @ 2006-03-11 15:20 UTC (permalink / raw)
To: Andrew Morotn; +Cc: Linux kernel mailing list, htejun, jgarzik
Hello,
this is in diff between -mm2 and -mm3:
ata2: SATA port has no device.
ata2: PIO error
ata2: dev 0 failed to IDENTIFY (I/O error)
These lines are new in dmesg.
Whole diff:
--- mm2 2006-03-11 15:50:21.000000000 +0100
+++ mm3 2006-03-11 15:49:11.000000000 +0100
@@ -1,4 +1,4 @@
-Linux version 2.6.16-rc5-mm2 (ku@bellona) (gcc version 4.1.0 20060214 (Red Hat 4.1.0-0.27)) #101 SMP PREEMPT Fri Mar 3 16:20:18 CET 2006
+Linux version 2.6.16-rc5-mm3 (ku@bellona) (gcc version 4.1.0 20060214 (Red Hat 4.1.0-0.27)) #102 SMP PREEMPT Thu Mar 9 23:49:35 CET 2006
BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
@@ -38,7 +38,7 @@
Enabling APIC mode: Flat. Using 1 I/O APICs
Using ACPI (MADT) for SMP configuration information
Allocating PCI resources starting at 30000000 (gap: 20000000:dec00000)
-Detected 2736.287 MHz processor.
+Detected 2736.432 MHz processor.
Built 1 zonelists
Kernel command line: ro root=/dev/hda2 reboot=w
mapped APIC to ffffd000 (fee00000)
@@ -51,9 +51,9 @@
Console: colour VGA+ 80x25
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
-Memory: 514404k/524224k available (2532k kernel code, 9360k reserved, 1380k data, 200k init, 0k highmem)
+Memory: 514404k/524224k available (2534k kernel code, 9360k reserved, 1378k data, 200k init, 0k highmem)
Checking if this processor honours the WP bit even in supervisor mode... Ok.
-Calibrating delay using timer specific routine.. 5476.83 BogoMIPS (lpj=10953674)
+Calibrating delay using timer specific routine.. 5476.78 BogoMIPS (lpj=10953574)
Mount-cache hash table entries: 512
CPU: After generic identify, caps: bfebfbff 00000000 00000000 00000000 00004400 00000000 00000000
CPU: After vendor identify, caps: bfebfbff 00000000 00000000 00000000 00004400 00000000 00000000
@@ -71,7 +71,7 @@
Booting processor 1/1 eip 2000
CPU 1 irqstacks, hard=c0513000 soft=c0510000
Initializing CPU#1
-Calibrating delay using timer specific routine.. 5472.84 BogoMIPS (lpj=10945697)
+Calibrating delay using timer specific routine.. 5472.77 BogoMIPS (lpj=10945557)
CPU: After generic identify, caps: bfebfbff 00000000 00000000 00000000 00004400 00000000 00000000
CPU: After vendor identify, caps: bfebfbff 00000000 00000000 00000000 00004400 00000000 00000000
CPU: Trace cache: 12K uops, L1 D cache: 8K
@@ -83,12 +83,12 @@
CPU1: Intel P4/Xeon Extended MCE MSRs (12) available
CPU1: Thermal monitoring enabled
CPU1: Intel(R) Pentium(R) 4 CPU 2.60GHz stepping 09
-Total of 2 processors activated (10949.68 BogoMIPS).
+Total of 2 processors activated (10949.56 BogoMIPS).
ENABLING IO-APIC IRQs
..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
checking TSC synchronization across 2 CPUs: passed.
Brought up 2 CPUs
-migration_cost=5
+migration_cost=145
NET: Registered protocol family 16
ACPI: bus type pci registered
PCI: Using configuration type 1
@@ -170,6 +170,7 @@
hda: hda1 hda2 hda3 hda4 < hda5 hda6 >
libata version 1.20 loaded.
ata_piix 0000:00:1f.2: version 1.05
+ata_piix 0000:00:1f.2: MAP [ P0 -- P1 -- ]
ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 18 (level, low) -> IRQ 18
PCI: Setting latency timer of device 0000:00:1f.2 to 64
ata1: SATA max UDMA/133 cmd 0xC000 ctl 0xC402 bmdma 0xD000 irq 18
@@ -177,8 +178,12 @@
ata1: dev 0 cfg 49:2f00 82:346b 83:7f21 84:4003 85:3469 86:3c01 87:4003 88:203f
ata1: dev 0 ATA-6, max UDMA/100, 234441648 sectors: LBA48
ata1(0): applying bridge limits
+ata1: dev 0 cfg 49:2f00 82:346b 83:7f21 84:4003 85:3469 86:3c01 87:4003 88:203f
ata1: dev 0 configured for UDMA/100
scsi0 : ata_piix
+ata2: SATA port has no device.
+ata2: PIO error
+ata2: dev 0 failed to IDENTIFY (I/O error)
scsi1 : ata_piix
Vendor: ATA Model: WDC WD1200JD-00F Rev: 02.0
Type: Direct-Access ANSI SCSI revision: 05
@@ -203,7 +208,7 @@
usb usb1: new device found, idVendor=0000, idProduct=0000
usb usb1: new device strings: Mfr=3, Product=2, SerialNumber=1
usb usb1: Product: EHCI Host Controller
-usb usb1: Manufacturer: Linux 2.6.16-rc5-mm2 ehci_hcd
+usb usb1: Manufacturer: Linux 2.6.16-rc5-mm3 ehci_hcd
usb usb1: SerialNumber: 0000:00:1d.7
usb usb1: configuration #1 chosen from 1 choice
hub 1-0:1.0: USB hub found
@@ -217,7 +222,7 @@
usb usb2: new device found, idVendor=0000, idProduct=0000
usb usb2: new device strings: Mfr=3, Product=2, SerialNumber=1
usb usb2: Product: UHCI Host Controller
-usb usb2: Manufacturer: Linux 2.6.16-rc5-mm2 uhci_hcd
+usb usb2: Manufacturer: Linux 2.6.16-rc5-mm3 uhci_hcd
usb usb2: SerialNumber: 0000:00:1d.0
usb usb2: configuration #1 chosen from 1 choice
hub 2-0:1.0: USB hub found
@@ -230,7 +235,7 @@
usb usb3: new device found, idVendor=0000, idProduct=0000
usb usb3: new device strings: Mfr=3, Product=2, SerialNumber=1
usb usb3: Product: UHCI Host Controller
-usb usb3: Manufacturer: Linux 2.6.16-rc5-mm2 uhci_hcd
+usb usb3: Manufacturer: Linux 2.6.16-rc5-mm3 uhci_hcd
usb usb3: SerialNumber: 0000:00:1d.1
usb usb3: configuration #1 chosen from 1 choice
hub 3-0:1.0: USB hub found
@@ -243,7 +248,7 @@
usb usb4: new device found, idVendor=0000, idProduct=0000
usb usb4: new device strings: Mfr=3, Product=2, SerialNumber=1
usb usb4: Product: UHCI Host Controller
-usb usb4: Manufacturer: Linux 2.6.16-rc5-mm2 uhci_hcd
+usb usb4: Manufacturer: Linux 2.6.16-rc5-mm3 uhci_hcd
usb usb4: SerialNumber: 0000:00:1d.2
usb usb4: configuration #1 chosen from 1 choice
hub 4-0:1.0: USB hub found
@@ -256,7 +261,7 @@
usb usb5: new device found, idVendor=0000, idProduct=0000
usb usb5: new device strings: Mfr=3, Product=2, SerialNumber=1
usb usb5: Product: UHCI Host Controller
-usb usb5: Manufacturer: Linux 2.6.16-rc5-mm2 uhci_hcd
+usb usb5: Manufacturer: Linux 2.6.16-rc5-mm3 uhci_hcd
usb usb5: SerialNumber: 0000:00:1d.3
usb usb5: configuration #1 chosen from 1 choice
hub 5-0:1.0: USB hub found
@@ -294,25 +299,25 @@
NET: Registered protocol family 17
Starting balanced_irq
Using IPI Shortcut mode
+Time: tsc clocksource has been installed.
kjournald starting. Commit interval 5 seconds
EXT3-fs: mounted filesystem with ordered data mode.
VFS: Mounted root (ext3 filesystem) readonly.
Freeing unused kernel memory: 200k freed
-Time: tsc clocksource has been installed.
input: AT Translated Set 2 keyboard as /class/input/input1
-gameport: EMU10K1 is pci0000:02:02.1/gameport0, io 0xa400, speed 1065kHz
hdc: ATAPI 40X DVD-ROM DVD-R CD-R/RW drive, 2048kB Cache, UDMA(33)
Uniform CD-ROM driver Revision: 3.20
hdd: ATAPI 40X DVD-ROM CD-R/RW drive, 2048kB Cache, UDMA(33)
+gameport: EMU10K1 is pci0000:02:02.1/gameport0, io 0xa400, speed 1084kHz
ieee1394: Initialized config rom entry `ip1394'
ACPI: PCI Interrupt 0000:02:05.0[A] -> GSI 21 (level, low) -> IRQ 22
ohci1394: fw-host0: OHCI-1394 1.1 (PCI): IRQ=[22] MMIO=[fa004000-fa0047ff] Max Packet=[2048] IR/IT contexts=[4/8]
Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077
parport0: PC-style at 0x378 (0x778), irq 7 [PCSPP,TRISTATE]
+ieee1394: Host added: ID:BUS[0-00:1023] GUID[000d6100001a97a1]
EXT3 FS on hda2, internal journal
kjournald starting. Commit interval 5 seconds
-ieee1394: Host added: ID:BUS[0-00:1023] GUID[000d6100001a97a1]
EXT3 FS on hda5, internal journal
EXT3-fs: mounted filesystem with ordered data mode.
kjournald starting. Commit interval 5 seconds
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH] libata: fix missing classes[] initialization in ata_bus_probe()
2006-03-11 15:20 ` ata2: dev 0 failed to IDENTIFY (I/O error) [Was: 2.6.16-rc5-mm3] Jiri Slaby
@ 2006-03-11 15:57 ` Tejun Heo
2006-03-12 0:05 ` Jeff Garzik
0 siblings, 1 reply; 24+ messages in thread
From: Tejun Heo @ 2006-03-11 15:57 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Andrew Morotn, Linux kernel mailing list, jgarzik
ata_bus_probe() didn't initialize classes[] properly with
ATA_DEV_UNKNOWN. As ->probe_reset() is allowed to leave @classes
alone when no device is present, this results in garbage class values.
ATM, the only affected driver is ata_piix.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
---
Jiri, thanks for reporting this. The offending change has been there
for some time but it's the first time I see it. Probably because my
garbage was never ATA_DEV_ATA or ATA_DEV_ATAPI.
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 5dbcf0c..d7f9f1a 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1237,6 +1237,9 @@ static int ata_bus_probe(struct ata_port
/* reset */
if (ap->ops->probe_reset) {
+ for (i = 0; i < ATA_MAX_DEVICES; i++)
+ classes[i] = ATA_DEV_UNKNOWN;
+
rc = ap->ops->probe_reset(ap, classes);
if (rc) {
printk("ata%u: reset failed (errno=%d)\n", ap->id, rc);
^ permalink raw reply related [flat|nested] 24+ messages in thread