public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	akpm@osdl.org, paulus@samba.org, bcrl@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Define flush_wc, a way to flush write combining store buffers
Date: Wed, 8 Mar 2006 15:21:18 +0100	[thread overview]
Message-ID: <200603081521.19693.ak@suse.de> (raw)
In-Reply-To: <1141854208.27555.1.camel@localhost.localdomain>

On Wednesday 08 March 2006 22:43, Bryan O'Sullivan wrote:
> On Thu, 2006-03-09 at 08:38 +1100, Benjamin Herrenschmidt wrote:
> 
> > I think people already don't undersatnd the existing gazillion of
> > barriers we have with quite unclear semantics in some cases, it's not
> > time to add a new one ...
> 
> What do you suggest I do, then?  This makes a substantial difference to
> performance for us.  Should I confine this somehow to the ipath driver
> directory and have a nest of ifdefs in an include file there?

I think doing it privately is the better solution because I don't think you 
have established it has an universal semantic that works
on all X86-64 systems.

And we don't have a portable way to do WC anyways, so there is 
no portable way to use it.

So just put an ifdef in.

-Andi

  reply	other threads:[~2006-03-08 21:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-08 21:31 [PATCH] Define flush_wc, a way to flush write combining store buffers Bryan O'Sullivan
2006-03-08 21:38 ` Benjamin Herrenschmidt
2006-03-08 21:37   ` Benjamin LaHaise
2006-03-08 21:43   ` Bryan O'Sullivan
2006-03-08 14:21     ` Andi Kleen [this message]
2006-03-08 21:57       ` Bryan O'Sullivan
2006-03-08 14:38         ` Andi Kleen
2006-03-09  1:26           ` Bryan O'Sullivan
2006-03-08 23:40     ` Benjamin Herrenschmidt
2006-03-09  1:48       ` Bryan O'Sullivan
2006-03-08 22:06 ` Alan Cox
2006-03-08 14:35   ` Andi Kleen
2006-03-08 22:05     ` Bryan O'Sullivan
2006-03-08 14:40       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603081521.19693.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=bcrl@kvack.org \
    --cc=benh@kernel.crashing.org \
    --cc=bos@pathscale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox