From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbWCHVbQ (ORCPT ); Wed, 8 Mar 2006 16:31:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932521AbWCHVbP (ORCPT ); Wed, 8 Mar 2006 16:31:15 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:38868 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932472AbWCHVbO (ORCPT ); Wed, 8 Mar 2006 16:31:14 -0500 Date: Wed, 8 Mar 2006 21:31:07 +0000 From: Christoph Hellwig To: David Howells Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] NFS: Add dentry materialisation op [try #7] Message-ID: <20060308213107.GC8042@infradead.org> Mail-Followup-To: Christoph Hellwig , David Howells , akpm@osdl.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20060308203018.25493.23720.stgit@warthog.cambridge.redhat.com> <20060308203026.25493.17935.stgit@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060308203026.25493.17935.stgit@warthog.cambridge.redhat.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > (*) _d_rehash() has been added as a wrapper around __d_rehash() to call it > with the most obvious hash list (the one from the name). d_rehash() now > calls _d_rehash(). We're not really kean on single _ prefix functions. Could you give it a saner name instead (or a new one for __d_rehash and rename _d_reshash to that)