* drivers/media/video/saa7115.c misreports max. value of contrast and saturation @ 2006-02-15 5:19 Kyler Laird 2006-03-08 21:19 ` Adrian Bunk 0 siblings, 1 reply; 6+ messages in thread From: Kyler Laird @ 2006-02-15 5:19 UTC (permalink / raw) To: linux-kernel For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum value in v4l2_queryctrl is set to 255 for both of these items. This means that programs (like MythTV) which set the contrast and saturation to the midvalue (127) get *full* contrast and saturation. (It's not pretty.) Setting the maximum values to 127 solves this problem. Please copy me on responses. Thank you. --kyler ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation 2006-02-15 5:19 drivers/media/video/saa7115.c misreports max. value of contrast and saturation Kyler Laird @ 2006-03-08 21:19 ` Adrian Bunk 2006-03-08 21:42 ` [v4l-dvb-maintainer] " Hans Verkuil 2006-03-08 22:47 ` Mauro Carvalho Chehab 0 siblings, 2 replies; 6+ messages in thread From: Adrian Bunk @ 2006-03-08 21:19 UTC (permalink / raw) To: Kyler Laird, mchehab; +Cc: linux-kernel, v4l-dvb-maintainer On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote: > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is > checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum > value in v4l2_queryctrl is set to 255 for both of these items. This > means that programs (like MythTV) which set the contrast and saturation > to the midvalue (127) get *full* contrast and saturation. (It's not > pretty.) > > Setting the maximum values to 127 solves this problem. Mauro, can you comment on this issue? > Please copy me on responses. > > Thank you. > > --kyler cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [v4l-dvb-maintainer] Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation 2006-03-08 21:19 ` Adrian Bunk @ 2006-03-08 21:42 ` Hans Verkuil 2006-03-08 22:47 ` Mauro Carvalho Chehab 1 sibling, 0 replies; 6+ messages in thread From: Hans Verkuil @ 2006-03-08 21:42 UTC (permalink / raw) To: v4l-dvb-maintainer; +Cc: Adrian Bunk, Kyler Laird, mchehab, linux-kernel On Wednesday 08 March 2006 22:19, Adrian Bunk wrote: > On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote: > > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value > > is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the > > maximum value in v4l2_queryctrl is set to 255 for both of these > > items. This means that programs (like MythTV) which set the > > contrast and saturation to the midvalue (127) get *full* contrast > > and saturation. (It's not pretty.) > > > > Setting the maximum values to 127 solves this problem. > > Mauro, can you comment on this issue? It's fixed with the patch with subject '[PATCH 08/13] Fix maximum for the saturation and contrast controls.' It was posted by Mauro to the linux mailinglist a week ago. I hope it will be fixed in 2.6.16, but Mauro should know more about it. It was a stupid copy-and-paste bug so I see no reason why it shouldn't go in. > > Please copy me on responses. > > > > Thank you. > > > > --kyler > > cu > Adrian ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation 2006-03-08 21:19 ` Adrian Bunk 2006-03-08 21:42 ` [v4l-dvb-maintainer] " Hans Verkuil @ 2006-03-08 22:47 ` Mauro Carvalho Chehab 2006-03-08 23:46 ` Adrian Bunk 1 sibling, 1 reply; 6+ messages in thread From: Mauro Carvalho Chehab @ 2006-03-08 22:47 UTC (permalink / raw) To: Adrian Bunk; +Cc: Kyler Laird, linux-kernel, v4l-dvb-maintainer Adrian, Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu: > On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote: > > > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is > > checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum > > value in v4l2_queryctrl is set to 255 for both of these items. This > > means that programs (like MythTV) which set the contrast and saturation > > to the midvalue (127) get *full* contrast and saturation. (It's not > > pretty.) > > > > Setting the maximum values to 127 solves this problem. > > Mauro, can you comment on this issue? Yes. Patch is already available at both git and mercurial trees, fixing it for saa7115 and cx25840: http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb > > > Please copy me on responses. > > > > Thank you. > > > > --kyler > > cu > Adrian > Cheers, Mauro. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation 2006-03-08 22:47 ` Mauro Carvalho Chehab @ 2006-03-08 23:46 ` Adrian Bunk 2006-03-09 0:21 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 6+ messages in thread From: Adrian Bunk @ 2006-03-08 23:46 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Kyler Laird, linux-kernel, v4l-dvb-maintainer On Wed, Mar 08, 2006 at 07:47:43PM -0300, Mauro Carvalho Chehab wrote: > Adrian, > > > Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu: > > On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote: > > > > > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is > > > checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum > > > value in v4l2_queryctrl is set to 255 for both of these items. This > > > means that programs (like MythTV) which set the contrast and saturation > > > to the midvalue (127) get *full* contrast and saturation. (It's not > > > pretty.) > > > > > > Setting the maximum values to 127 solves this problem. > > > > Mauro, can you comment on this issue? > Yes. Patch is already available at both git and mercurial trees, fixing > it for saa7115 and cx25840: > > http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb This patch seems to be 2.1.16 stuff? > Cheers, > Mauro. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation 2006-03-08 23:46 ` Adrian Bunk @ 2006-03-09 0:21 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 6+ messages in thread From: Mauro Carvalho Chehab @ 2006-03-09 0:21 UTC (permalink / raw) To: Adrian Bunk; +Cc: Kyler Laird, linux-kernel, v4l-dvb-maintainer Em Qui, 2006-03-09 às 00:46 +0100, Adrian Bunk escreveu: > On Wed, Mar 08, 2006 at 07:47:43PM -0300, Mauro Carvalho Chehab wrote: > > Adrian, > > > > > > Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu: > > > On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote: > > > > > > > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is > > > > checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum > > > > value in v4l2_queryctrl is set to 255 for both of these items. This > > > > means that programs (like MythTV) which set the contrast and saturation > > > > to the midvalue (127) get *full* contrast and saturation. (It's not > > > > pretty.) > > > > > > > > Setting the maximum values to 127 solves this problem. > > > > > > Mauro, can you comment on this issue? > > Yes. Patch is already available at both git and mercurial trees, fixing > > it for saa7115 and cx25840: > > > > http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb > > This patch seems to be 2.1.16 stuff? I think you meant 2.6.16 :) Yes, it is. I've already sent an email to Linus for him to pull it, among with some other pending patches. > > > Cheers, > > Mauro. > > cu > Adrian > Cheers, Mauro. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-03-09 0:22 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-02-15 5:19 drivers/media/video/saa7115.c misreports max. value of contrast and saturation Kyler Laird 2006-03-08 21:19 ` Adrian Bunk 2006-03-08 21:42 ` [v4l-dvb-maintainer] " Hans Verkuil 2006-03-08 22:47 ` Mauro Carvalho Chehab 2006-03-08 23:46 ` Adrian Bunk 2006-03-09 0:21 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox