From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: raven@themaw.net
Subject: Remove redundant check from autofs4_put_super
Date: Wed, 8 Mar 2006 22:05:42 -0500 [thread overview]
Message-ID: <20060309030542.GA17851@redhat.com> (raw)
We have to have a valid sbi here, or we'd have oopsed already.
(There's a dereference of sbi->catatonic a few lines above)
Coverity #740
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/fs/autofs4/inode.c~ 2006-03-08 22:02:53.000000000 -0500
+++ linux-2.6/fs/autofs4/inode.c 2006-03-08 22:03:47.000000000 -0500
@@ -145,8 +145,7 @@ static void autofs4_put_super(struct sup
autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */
/* Clean up and release dangling references */
- if (sbi)
- autofs4_force_release(sbi);
+ autofs4_force_release(sbi);
kfree(sbi);
--
http://www.codemonkey.org.uk
reply other threads:[~2006-03-09 3:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309030542.GA17851@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox