* Remove redundant check from autofs4_put_super
@ 2006-03-09 3:05 Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2006-03-09 3:05 UTC (permalink / raw)
To: Linux Kernel; +Cc: raven
We have to have a valid sbi here, or we'd have oopsed already.
(There's a dereference of sbi->catatonic a few lines above)
Coverity #740
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/fs/autofs4/inode.c~ 2006-03-08 22:02:53.000000000 -0500
+++ linux-2.6/fs/autofs4/inode.c 2006-03-08 22:03:47.000000000 -0500
@@ -145,8 +145,7 @@ static void autofs4_put_super(struct sup
autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */
/* Clean up and release dangling references */
- if (sbi)
- autofs4_force_release(sbi);
+ autofs4_force_release(sbi);
kfree(sbi);
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-09 3:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-09 3:05 Remove redundant check from autofs4_put_super Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox