From: Horms <horms@verge.net.au>
To: linux-kernel@vger.kernel.org
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: [PATCH] NFS Client: remove supurflous goto from nfs_create_client()
Date: Thu, 9 Mar 2006 18:23:45 +0900 [thread overview]
Message-ID: <20060309092341.GA26949@verge.net.au> (raw)
The out_fail label in nfs_create_client just returns clnt,
which happens to be a duplicate of a return immediately above.
Remove the label and instead of calling goto out_fail (once),
just return clnt.
Signed-Off-By: Horms <horms@verge.net.au>
inode.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index a77ee95..367d62c 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -408,16 +408,13 @@ nfs_create_client(struct nfs_server *ser
if (IS_ERR(clnt)) {
dprintk("%s: cannot create RPC client. Error = %ld\n",
__FUNCTION__, PTR_ERR(xprt));
- goto out_fail;
+ return clnt;
}
clnt->cl_intr = 1;
clnt->cl_softrtry = 1;
return clnt;
-
-out_fail:
- return clnt;
}
/*
next reply other threads:[~2006-03-09 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 9:23 Horms [this message]
2006-03-10 1:03 ` [PATCH] NFS Client: remove supurflous goto from nfs_create_client() Sam Vilain
2006-03-10 2:24 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309092341.GA26949@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox