From: Paul Dickson <dickson@permanentmail.com>
To: NeilBrown <neilb@suse.de>
Cc: akpm@osdl.org, nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001 of 14] knfsd: Change the store of auth_domains to not be a 'cache'.
Date: Thu, 9 Mar 2006 09:26:37 -0700 [thread overview]
Message-ID: <20060309092637.4d008f97.dickson@permanentmail.com> (raw)
In-Reply-To: <1060309065127.24521@suse.de>
On Thu, 9 Mar 2006 17:51:27 +1100, NeilBrown wrote:
> struct auth_domain *unix_domain_find(char *name)
> {
> - [code deletions removed]
> + struct auth_domain *rv;
> + struct unix_domain *new = NULL;
>
> - [code deletions removed]
> + rv = auth_domain_lookup(name, NULL);
> + while(1) {
> + if (rv != &new->h) {
> + if (new) auth_domain_put(&new->h);
> + return rv;
> + }
> + new = kmalloc(sizeof(*new), GFP_KERNEL);
> + if (new == NULL)
> + return NULL;
My C skills are a bit rusty, but is seems the value of new is offsetted
while still NULL. I could not find any further updates in the patch
series.
-Paul
next prev parent reply other threads:[~2006-03-09 16:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 6:51 [PATCH 000 of 14] knfsd: Introduction NeilBrown
2006-03-09 6:51 ` [PATCH 001 of 14] knfsd: Change the store of auth_domains to not be a 'cache' NeilBrown
2006-03-09 16:26 ` Paul Dickson [this message]
2006-03-09 6:51 ` [PATCH 002 of 14] knfsd: Break the hard linkage from svc_expkey to svc_export NeilBrown
2006-03-09 6:51 ` [PATCH 003 of 14] knfsd: Get rid of 'inplace' sunrpc caches NeilBrown
2006-03-09 6:51 ` [PATCH 004 of 14] knfsd: Create cache_lookup function instead of using a macro to declare one NeilBrown
2006-03-09 6:51 ` [PATCH 005 of 14] knfsd: Convert ip_map cache to use the new lookup routine NeilBrown
2006-03-09 6:51 ` [PATCH 006 of 14] knfsd: Use new cache_lookup for svc_export NeilBrown
2006-03-09 6:51 ` [PATCH 007 of 14] knfsd: Use new cache_lookup for svc_expkey cache NeilBrown
2006-03-09 6:52 ` [PATCH 008 of 14] knfsd: Use new sunrpc cache for rsi cache NeilBrown
2006-03-09 6:52 ` [PATCH 009 of 14] knfsd: Use new cache code for rsc cache NeilBrown
2006-03-09 6:52 ` [PATCH 010 of 14] knfsd: Use new cache code for name/id lookup caches NeilBrown
2006-03-09 6:52 ` [PATCH 011 of 14] knfsd: An assortment of little fixes to the sunrpc cache code NeilBrown
2006-03-09 6:52 ` [PATCH 012 of 14] knfsd: Remove DefineCacheLookup NeilBrown
2006-03-09 6:52 ` [PATCH 013 of 14] knfsd: Unexport cache_fresh and fix a small race NeilBrown
2006-03-09 6:52 ` [PATCH 014 of 14] knfsd: Convert sunrpc_cache to use krefs NeilBrown
2006-03-09 17:10 ` [PATCH 000 of 14] knfsd: Introduction Trond Myklebust
2006-03-10 0:54 ` Neil Brown
2006-03-13 11:41 ` [NFS] " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309092637.4d008f97.dickson@permanentmail.com \
--to=dickson@permanentmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox