Re: [PATCH] drivers/ieee1394/ohci1394.c: function calls without effect

[Adrian Bunk <bunk@stusta.de>]

On Thu, Mar 09, 2006 at 02:18:28PM +0100, Stefan Richter wrote:
> ohci1394: Remove superfluous call to free_dma_rcv_ctx,
> spotted by Adrian Bunk. Also remove some superfluous comments.
> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> 
> Index: linux/drivers/ieee1394/ohci1394.c
> ===================================================================
> --- linux.orig/drivers/ieee1394/ohci1394.c     2006-03-06 20:04:10.000000000 +0100
> +++ linux/drivers/ieee1394/ohci1394.c  2006-03-09 14:09:21.000000000 +0100
> @@ -3462,24 +3462,13 @@ static void ohci1394_pci_remove(struct p
>  	case OHCI_INIT_HAVE_TXRX_BUFFERS__MAYBE:
>  		/* The ohci_soft_reset() stops all DMA contexts, so we
>  		 * dont need to do this.  */
> -		/* Free AR dma */
>  		free_dma_rcv_ctx(&ohci->ar_req_context);
>  		free_dma_rcv_ctx(&ohci->ar_resp_context);
> -
> -		/* Free AT dma */
>  		free_dma_trm_ctx(&ohci->at_req_context);
>  		free_dma_trm_ctx(&ohci->at_resp_context);
> -
> -		/* Free IR dma */
>  		free_dma_rcv_ctx(&ohci->ir_legacy_context);
> -
> -		/* Free IT dma */
>  		free_dma_trm_ctx(&ohci->it_legacy_context);
>...

Unless I'm mireading the code, it's impossible after the call of 
free_dma_rcv_ctx() that free_dma_trm_ctx() will do anything.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed