From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH] fix potential null deref in kallsyms::read_symbol
Date: Thu, 9 Mar 2006 23:02:29 +0100 [thread overview]
Message-ID: <200603092302.29634.jesper.juhl@gmail.com> (raw)
The Coverity checker found that if malloc() fails in
scripts/kallsyms.c::read_symbol() then we end up dereferencing a NULL pointer.
Unlikely to happen, but we really should check the malloc() return value.
This patch fixes the problem by checking the return value and printing a nice
descriptive error message and exiting if malloc() did fail.
This fixes coverity error #397
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
scripts/kallsyms.c | 5 +++++
1 files changed, 5 insertions(+)
--- linux-2.6.16-rc5-git12-orig/scripts/kallsyms.c 2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc5-git12/scripts/kallsyms.c 2006-03-09 22:57:13.000000000 +0100
@@ -124,6 +124,11 @@ static int read_symbol(FILE *in, struct
* compressed together */
s->len = strlen(str) + 1;
s->sym = malloc(s->len + 1);
+ if (!s->sym) {
+ fprintf(stderr, "kallsyms failure: "
+ "unable to allocate required amount of memory\n");
+ exit(EXIT_FAILURE);
+ }
strcpy((char *)s->sym + 1, str);
s->sym[0] = stype;
reply other threads:[~2006-03-09 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603092302.29634.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox