* [PATCH] fix potential null deref in kallsyms::read_symbol
@ 2006-03-09 22:02 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-03-09 22:02 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Jesper Juhl
The Coverity checker found that if malloc() fails in
scripts/kallsyms.c::read_symbol() then we end up dereferencing a NULL pointer.
Unlikely to happen, but we really should check the malloc() return value.
This patch fixes the problem by checking the return value and printing a nice
descriptive error message and exiting if malloc() did fail.
This fixes coverity error #397
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
scripts/kallsyms.c | 5 +++++
1 files changed, 5 insertions(+)
--- linux-2.6.16-rc5-git12-orig/scripts/kallsyms.c 2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc5-git12/scripts/kallsyms.c 2006-03-09 22:57:13.000000000 +0100
@@ -124,6 +124,11 @@ static int read_symbol(FILE *in, struct
* compressed together */
s->len = strlen(str) + 1;
s->sym = malloc(s->len + 1);
+ if (!s->sym) {
+ fprintf(stderr, "kallsyms failure: "
+ "unable to allocate required amount of memory\n");
+ exit(EXIT_FAILURE);
+ }
strcpy((char *)s->sym + 1, str);
s->sym[0] = stype;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-09 22:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-09 22:02 [PATCH] fix potential null deref in kallsyms::read_symbol Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox