From: Al Viro <viro@ftp.linux.org.uk>
To: Kyle Moffett <mrmacman_g4@mac.com>
Cc: "Bryan O'Sullivan" <bos@serpentine.com>,
"David S. Miller" <davem@davemloft.net>,
davej@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: filldir[64] oddness
Date: Fri, 10 Mar 2006 01:44:57 +0000 [thread overview]
Message-ID: <20060310014457.GV27946@ftp.linux.org.uk> (raw)
In-Reply-To: <0A5868C4-CC2D-443D-8340-9F0AB2E0A94C@mac.com>
On Thu, Mar 09, 2006 at 08:41:08PM -0500, Kyle Moffett wrote:
> Yeah, IMHO it's not really worth optimizing for the obscure and oddly-
> defined cases unless you can actually find valid places where that
> code comes up understandably. In this particular case, the Coverity
> checker is indirectly pointing out that the code is confusing to the
> reader and could inadvertently be massively broken by changing the
> type of d_name.
Bullshit. It is very directly pointing out that it has broken handling
of C types (obscure case, my arse - decay of arrays to pointers), has no
regression testsuite and most likely doesn't even get applied to its own
source on a regular basis.
next prev parent reply other threads:[~2006-03-10 1:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 4:27 filldir[64] oddness Dave Jones
2006-03-09 4:32 ` David S. Miller
2006-03-09 4:38 ` Dave Jones
2006-03-09 4:40 ` Al Viro
2006-03-09 17:02 ` Bryan O'Sullivan
2006-03-09 17:07 ` Dave Jones
2006-03-09 17:15 ` Bryan O'Sullivan
2006-03-09 17:27 ` Dave Jones
2006-03-10 1:41 ` Kyle Moffett
2006-03-10 1:44 ` Al Viro [this message]
2006-03-09 4:33 ` Vadim Lobanov
2006-03-09 4:34 ` Stephen Rothwell
2006-03-09 4:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060310014457.GV27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=bos@serpentine.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mrmacman_g4@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox