public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/scsi/ibmmca.c: fix a NULL pointer dereference
@ 2006-03-10 22:24 Adrian Bunk
  0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-03-10 22:24 UTC (permalink / raw)
  To: langa2; +Cc: James.Bottomley, linux-scsi, linux-kernel

The variable was dereferenced only if it was NULL (sic)...

Spotted by the Coverity checker.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.16-rc5-mm3-full/drivers/scsi/ibmmca.c.old	2006-03-10 20:39:03.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/scsi/ibmmca.c	2006-03-10 20:41:47.000000000 +0100
@@ -2357,8 +2357,7 @@ static int ibmmca_proc_info(struct Scsi_
 	spin_lock_irqsave(hosts[i]->host_lock, flags);	/* Check it */
 	host_index = i;
 	if (!shpnt) {
-		len += sprintf(buffer + len, "\nIBM MCA SCSI: Can't find adapter for host number %d\n",
-				shpnt->host_no);
+		len += sprintf(buffer + len, "\nIBM MCA SCSI: Can't find adapter");
 		return len;
 	}
 	max_pun = subsystem_maxid(host_index);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-03-10 22:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-10 22:24 [2.6 patch] drivers/scsi/ibmmca.c: fix a NULL pointer dereference Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox