public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: garloff@suse.de, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] KERN_SETUID_DUMPABLE in /proc/sys/fs/
Date: Fri, 10 Mar 2006 23:41:55 -0800	[thread overview]
Message-ID: <20060310234155.685456cd.akpm@osdl.org> (raw)
In-Reply-To: <1142061816.3055.6.camel@laptopd505.fenrus.org>

Arjan van de Ven <arjan@infradead.org> wrote:
>
> On Fri, 2006-03-10 at 14:56 -0800, Andrew Morton wrote:
> > Kurt Garloff <garloff@suse.de> wrote:
> > >
> > > Diffing in sysctl.c is tricky, using more context is recommended.
> > > suid_dumpable ended up in fs/ instead of kernel/ and the reason
> > > is likely a patch with too little context.
> > 
> > It's been in kernel/ since 2.6.13.  What will break if we move it?
> > 
> > This is security-related.  If we move it we risk unsecuring people's
> > machines...
> 
> only a very little bit since the default value is "secure", the option
> is to make it "insecure"...

OK, that's a good point.

> but yeah by this time we should just bite the bullet and rename the
> variable rather than move it about

That wouldn't help - we'll still break existing scripts.

crap.  I tend to think we leave it where it is - it's only a cosmetic
irritation, isn't it?

  reply	other threads:[~2006-03-11  7:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10 15:57 [PATCH] KERN_SETUID_DUMPABLE in /proc/sys/fs/ Kurt Garloff
2006-03-10 22:56 ` Andrew Morton
2006-03-11  7:23   ` Arjan van de Ven
2006-03-11  7:41     ` Andrew Morton [this message]
2006-03-11  7:47       ` Arjan van de Ven
2006-03-11  7:51         ` Andrew Morton
2006-03-11  8:04           ` Arjan van de Ven
2006-03-11 12:09             ` Jan Engelhardt
2006-03-12 22:07             ` Eric W. Biederman
2006-03-12 22:32               ` Kurt Garloff
2006-03-12 23:39                 ` Eric W. Biederman
2006-03-13  8:00               ` Arjan van de Ven
2006-03-13 15:06                 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060310234155.685456cd.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=garloff@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox