public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Blunck <jblunck@suse.de>
To: Neil Brown <neilb@suse.de>
Cc: Kirill Korotaev <dev@openvz.org>,
	akpm@osdl.org, viro@zeniv.linux.org.uk, olh@suse.de,
	bsingharora@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (3rd updated patch)]
Date: Mon, 13 Mar 2006 00:03:31 +0100	[thread overview]
Message-ID: <20060312230331.GO4243@hasse.suse.de> (raw)
In-Reply-To: <17428.39221.861124.797480@cse.unsw.edu.au>

On Mon, Mar 13, Neil Brown wrote:

> No you don't.

Err, you are right. But this brings a new idea to my mind: why don't we use
s_umount to prevent umounting while we prune one dentry? Something like:

  if (down_read_trylock()) {
    if (s_root)
      prune_one_dentry()
    up_read()
  }
  // else just skip it

So maybe our prunes counter isn't the only way to go. Comments?

Regards,
	Jan

-- 
Jan Blunck                                               jblunck@suse.de
SuSE LINUX AG - A Novell company
Maxfeldstr. 5                                          +49-911-74053-608
D-90409 Nürnberg                                      http://www.suse.de

  reply	other threads:[~2006-03-12 23:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-09 16:58 [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (3rd updated patch)] Jan Blunck
2006-03-09 17:07 ` Kirill Korotaev
2006-03-10  5:09   ` Neil Brown
2006-03-10  8:28     ` Kirill Korotaev
2006-03-10 10:59       ` Jan Blunck
2006-03-10 11:23         ` Kirill Korotaev
2006-03-10 11:56           ` Neil Brown
2006-03-10 12:02           ` Jan Blunck
2006-03-10 12:19             ` Kirill Korotaev
2006-03-10 11:51         ` Neil Brown
2006-03-10 12:31           ` Jan Blunck
2006-03-10 17:17             ` Balbir Singh
2006-03-12 21:57             ` Neil Brown
2006-03-12 23:03               ` Jan Blunck [this message]
2006-03-13  5:45                 ` Neil Brown
2006-03-13 15:52                   ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060312230331.GO4243@hasse.suse.de \
    --to=jblunck@suse.de \
    --cc=akpm@osdl.org \
    --cc=bsingharora@gmail.com \
    --cc=dev@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=olh@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox