Re: [PATCH][RFC] mm: swsusp shrink_all_memory tweaks

Nick Piggin
2006-03-18T04:41:24Z

Con Kolivas wrote:

> @@ -1567,7 +1546,7 @@ loop_again:
> zone->temp_priority = DEF_PRIORITY;
> }
>
> - for (priority = DEF_PRIORITY; priority >= 0; priority--) {
> + for_each_priority_reverse(priority) {

What's this for? The for loop is simple and easy to read, after
the change, you have to look somewhere else to see what it does.

> Index: linux-2.6.16-rc6-mm1/include/linux/swap.h
> ===================================================================
> --- linux-2.6.16-rc6-mm1.orig/include/linux/swap.h 2006-03-18 13:29:38.000000000 +1100
> +++ linux-2.6.16-rc6-mm1/include/linux/swap.h 2006-03-18 14:50:11.000000000 +1100
> @@ -66,6 +66,51 @@ typedef struct {
> unsigned long val;
> } swp_entry_t;
>
> +struct scan_control {

Why did you put this here? scan_control really can't go outside vmscan.c,
it is meant only to ease the passing of lots of parameters, and not as a
consistent interface.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com