* [PATCH] Ext2 flags shouldn't report "nogrpid".
@ 2006-03-13 21:08 Rob Landley
0 siblings, 0 replies; only message in thread
From: Rob Landley @ 2006-03-13 21:08 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
Signed-off-by: Rob Landley <rob@landley.net>
If I mount ext2 "rw", I want it to say "rw", not "rw,nogrpid".
--
I caught this writing an automated regression test script for the busybox
mount command. The symptom is
/dev/loop0 on /images/ext2.dir type ext2 (rw,nogrpid)
instead of:
/dev/loop0 on /images/ext2.dir type ext2 (rw)
The behavior was introduced by git commit
8fc2751beb0941966d3a97b26544e8585e428c08.
Rob
--
Never bet against the cheap plastic solution.
[-- Attachment #2: ext2.diff --]
[-- Type: text/x-diff, Size: 355 bytes --]
--- linux-2.6.16-rc5/fs/ext2/super.c 2006-02-27 00:09:35.000000000 -0500
+++ linux-2.6.16-rc5.new/fs/ext2/super.c 2006-03-13 15:55:15.000000000 -0500
@@ -210,8 +210,6 @@
if (sbi->s_mount_opt & EXT2_MOUNT_GRPID)
seq_puts(seq, ",grpid");
- else
- seq_puts(seq, ",nogrpid");
#if defined(CONFIG_QUOTA)
if (sbi->s_mount_opt & EXT2_MOUNT_USRQUOTA)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-13 21:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-13 21:08 [PATCH] Ext2 flags shouldn't report "nogrpid" Rob Landley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox