public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/input/gameport/gameport.c: fix a memory leak
@ 2006-03-11 15:10 Adrian Bunk
  2006-03-14  5:18 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-03-11 15:10 UTC (permalink / raw)
  To: dtor_core; +Cc: linux-input, linux-kernel

This patch fixes a memory leak found by the Coverity checker.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.16-rc5-mm3-full/drivers/input/gameport/gameport.c.old	2006-03-11 14:28:35.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/input/gameport/gameport.c	2006-03-11 14:28:53.000000000 +0100
@@ -266,6 +266,7 @@ static void gameport_queue_event(void *o
 	if ((event = kmalloc(sizeof(struct gameport_event), GFP_ATOMIC))) {
 		if (!try_module_get(owner)) {
 			printk(KERN_WARNING "gameport: Can't get module reference, dropping event %d\n", event_type);
+			kfree(event);
 			goto out;
 		}
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] drivers/input/gameport/gameport.c: fix a memory leak
  2006-03-11 15:10 [2.6 patch] drivers/input/gameport/gameport.c: fix a memory leak Adrian Bunk
@ 2006-03-14  5:18 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2006-03-14  5:18 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-input, linux-kernel

On Saturday 11 March 2006 10:10, Adrian Bunk wrote:
> This patch fixes a memory leak found by the Coverity checker.
>

Both patches applied, thank you Adrian.

Because the leak is very hard to trigger it will not be merged until
2.6.17 opens up.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-03-14  5:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-11 15:10 [2.6 patch] drivers/input/gameport/gameport.c: fix a memory leak Adrian Bunk
2006-03-14  5:18 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox