public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Andrew Morton <akpm@osdl.org>
Cc: Rob Landley <rob@landley.net>, linux-kernel@vger.kernel.org
Subject: Re: How do I get the ext3 driver to shut up?
Date: Tue, 14 Mar 2006 09:48:49 -0500	[thread overview]
Message-ID: <20060314144849.GC16264@thunk.org> (raw)
In-Reply-To: <20060313231407.7606f0d3.akpm@osdl.org>

On Mon, Mar 13, 2006 at 11:14:07PM -0800, Andrew Morton wrote:
> >  Guess which device driver feels a bit chatty?
> > 
> > ...
> >
> >  VFS: Can't find ext3 filesystem on dev loop0.
> 
> That's only printed if the sys_mount() caller set MS_VERBOSE in `flags'.

I should have been a bit more explict in my previous message.
Actually, if you trace down the logic, it's only printed if
sys_mount() __DIDN'T__ set MS_VERBOSE in 'flags'.  The code in
fs/super.c sets the "silent" flag if (flags & MS_VERBOSE) is non-zero.
The meaning is reversed, which is counterintuitive.  Hence, my patch.

						- Ted

  parent reply	other threads:[~2006-03-14 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14  3:18 How do I get the ext3 driver to shut up? Rob Landley
2006-03-14  3:30 ` Randy.Dunlap
2006-03-14 14:11   ` j4K3xBl4sT3r
2006-03-14 15:20   ` Rob Landley
2006-03-14 17:26     ` Randy.Dunlap
2006-03-14  7:14 ` Andrew Morton
2006-03-14 12:59   ` [PATCH] Fix backwards meaning of MS_VERBOSE Theodore Ts'o
2006-03-14 14:48   ` Theodore Ts'o [this message]
2006-03-14 16:41     ` How do I get the ext3 driver to shut up? Rob Landley
2006-03-14 20:09       ` Theodore Ts'o
2006-03-14 16:32   ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060314144849.GC16264@thunk.org \
    --to=tytso@mit.edu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox