* [PATCH ] drivers/scsi/scsi.c - export reprobe
@ 2006-03-14 0:52 Moore, Eric
2006-03-14 15:35 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Moore, Eric @ 2006-03-14 0:52 UTC (permalink / raw)
To: linux-scsi, linux-kernel; +Cc: James.Bottomley, hch, gregkh
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
Request for exporting device_reprobe -
This is scsi wrapper portion.
---------------------------------------------------
Adding support for exposing hidden raid components
for sg interface. The sdev->no_uld_attach flag
will set set accordingly.
The sas module supports adding/removing raid
volumes using online storage management application
interface.
This patch was provided to me by Christoph Hellwig.
Signed-off-by: Eric Moore <Eric.Moore@lsil.com>
[-- Attachment #2: scsi_device_reprobe --]
[-- Type: application/octet-stream, Size: 1162 bytes --]
Index: scsi-misc-2.6/drivers/scsi/scsi.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/scsi.c 2006-03-04 13:07:44.000000000 +0100
+++ scsi-misc-2.6/drivers/scsi/scsi.c 2006-03-07 21:57:21.000000000 +0100
@@ -1214,6 +1214,13 @@
}
EXPORT_SYMBOL(scsi_device_cancel);
+void scsi_device_reprobe(struct scsi_device *sdev)
+{
+ device_reprobe(&sdev->sdev_gendev);
+}
+
+EXPORT_SYMBOL(scsi_device_reprobe);
+
MODULE_DESCRIPTION("SCSI core");
MODULE_LICENSE("GPL");
Index: scsi-misc-2.6/include/scsi/scsi_device.h
===================================================================
--- scsi-misc-2.6.orig/include/scsi/scsi_device.h 2006-03-04 13:07:49.000000000 +0100
+++ scsi-misc-2.6/include/scsi/scsi_device.h 2006-03-07 21:57:45.000000000 +0100
@@ -204,6 +204,7 @@
uint target, uint lun);
extern void scsi_remove_device(struct scsi_device *);
extern int scsi_device_cancel(struct scsi_device *, int);
+extern void scsi_device_reprobe(struct scsi_device *);
extern int scsi_device_get(struct scsi_device *);
extern void scsi_device_put(struct scsi_device *);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] drivers/scsi/scsi.c - export reprobe
2006-03-14 0:52 [PATCH ] drivers/scsi/scsi.c - export reprobe Moore, Eric
@ 2006-03-14 15:35 ` Greg KH
2006-03-14 16:08 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2006-03-14 15:35 UTC (permalink / raw)
To: Moore, Eric; +Cc: linux-scsi, linux-kernel, James.Bottomley, hch
On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> Request for exporting device_reprobe -
> This is scsi wrapper portion.
Is this even really needed? It's just a single pointer dereference...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] drivers/scsi/scsi.c - export reprobe
2006-03-14 15:35 ` Greg KH
@ 2006-03-14 16:08 ` Christoph Hellwig
2006-03-14 16:31 ` Arjan van de Ven
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2006-03-14 16:08 UTC (permalink / raw)
To: Greg KH; +Cc: Moore, Eric, linux-scsi, linux-kernel, James.Bottomley, hch
On Tue, Mar 14, 2006 at 07:35:24AM -0800, Greg KH wrote:
> On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> > Request for exporting device_reprobe -
> > This is scsi wrapper portion.
>
> Is this even really needed? It's just a single pointer dereference...
We don't want SCSI LLDDs to know about implementations details like
sdev->sdev_gendev. Of course an inline or a macro could do this aswell.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH ] drivers/scsi/scsi.c - export reprobe
@ 2006-03-14 16:18 Moore, Eric
0 siblings, 0 replies; 6+ messages in thread
From: Moore, Eric @ 2006-03-14 16:18 UTC (permalink / raw)
To: Moore, Eric, linux-scsi, linux-kernel; +Cc: James.Bottomley, hch, gregkh
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Monday, March 13, 2006 5:53 PM, Eric Moore wrote:
>
> ---------------------------------------------------
> Adding support for exposing hidden raid components
> for sg interface. The sdev->no_uld_attach flag
> will set set accordingly.
>
> The sas module supports adding/removing raid
> volumes using online storage management application
> interface.
>
> This patch was provided to me by Christoph Hellwig.
>
> Signed-off-by: Eric Moore <Eric.Moore@lsil.com>
Here is repost of patch due to dos line endings.
[-- Attachment #2: scsi_device_reprobe --]
[-- Type: application/octet-stream, Size: 1162 bytes --]
Index: scsi-misc-2.6/drivers/scsi/scsi.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/scsi.c 2006-03-04 13:07:44.000000000 +0100
+++ scsi-misc-2.6/drivers/scsi/scsi.c 2006-03-07 21:57:21.000000000 +0100
@@ -1214,6 +1214,13 @@
}
EXPORT_SYMBOL(scsi_device_cancel);
+void scsi_device_reprobe(struct scsi_device *sdev)
+{
+ device_reprobe(&sdev->sdev_gendev);
+}
+
+EXPORT_SYMBOL(scsi_device_reprobe);
+
MODULE_DESCRIPTION("SCSI core");
MODULE_LICENSE("GPL");
Index: scsi-misc-2.6/include/scsi/scsi_device.h
===================================================================
--- scsi-misc-2.6.orig/include/scsi/scsi_device.h 2006-03-04 13:07:49.000000000 +0100
+++ scsi-misc-2.6/include/scsi/scsi_device.h 2006-03-07 21:57:45.000000000 +0100
@@ -204,6 +204,7 @@
uint target, uint lun);
extern void scsi_remove_device(struct scsi_device *);
extern int scsi_device_cancel(struct scsi_device *, int);
+extern void scsi_device_reprobe(struct scsi_device *);
extern int scsi_device_get(struct scsi_device *);
extern void scsi_device_put(struct scsi_device *);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] drivers/scsi/scsi.c - export reprobe
2006-03-14 16:08 ` Christoph Hellwig
@ 2006-03-14 16:31 ` Arjan van de Ven
0 siblings, 0 replies; 6+ messages in thread
From: Arjan van de Ven @ 2006-03-14 16:31 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Greg KH, Moore, Eric, linux-scsi, linux-kernel, James.Bottomley,
hch
On Tue, 2006-03-14 at 16:08 +0000, Christoph Hellwig wrote:
> On Tue, Mar 14, 2006 at 07:35:24AM -0800, Greg KH wrote:
> > On Mon, Mar 13, 2006 at 05:52:43PM -0700, Moore, Eric wrote:
> > > Request for exporting device_reprobe -
> > > This is scsi wrapper portion.
> >
> > Is this even really needed? It's just a single pointer dereference...
>
> We don't want SCSI LLDDs to know about implementations details like
> sdev->sdev_gendev. Of course an inline or a macro could do this aswell.
this looks like a good candidate for an inline yes ;)
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH ] drivers/scsi/scsi.c - export reprobe
@ 2006-03-14 22:02 Moore, Eric
0 siblings, 0 replies; 6+ messages in thread
From: Moore, Eric @ 2006-03-14 22:02 UTC (permalink / raw)
To: linux-scsi, linux-kernel; +Cc: James.Bottomley, hch, gregkh
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On Monday, March 13, 2006 5:53 PM, I wrote:
>
> Request for exporting device_reprobe -
> This is scsi wrapper portion.
>
> ---------------------------------------------------
> Adding support for exposing hidden raid components
> for sg interface. The sdev->no_uld_attach flag
> will set set accordingly.
>
> The sas module supports adding/removing raid
> volumes using online storage management application
> interface.
>
> This patch was provided to me by Christoph Hellwig.
>
> Signed-off-by: Eric Moore <Eric.Moore@lsil.com>
>
repost ( hopefully not mangled).
Eric Moore
[-- Attachment #2: scsi_device_reprobe --]
[-- Type: application/octet-stream, Size: 1136 bytes --]
Index: scsi-misc-2.6/drivers/scsi/scsi.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/scsi.c 2006-03-04 13:07:44.000000000 +0100
+++ scsi-misc-2.6/drivers/scsi/scsi.c 2006-03-07 21:57:21.000000000 +0100
@@ -1214,6 +1214,13 @@
}
EXPORT_SYMBOL(scsi_device_cancel);
+void scsi_device_reprobe(struct scsi_device *sdev)
+{
+ device_reprobe(&sdev->sdev_gendev);
+}
+
+EXPORT_SYMBOL_GPL(scsi_device_reprobe);
+
MODULE_DESCRIPTION("SCSI core");
MODULE_LICENSE("GPL");
Index: scsi-misc-2.6/include/scsi/scsi_device.h
===================================================================
--- scsi-misc-2.6.orig/include/scsi/scsi_device.h 2006-03-04 13:07:49.000000000 +0100
+++ scsi-misc-2.6/include/scsi/scsi_device.h 2006-03-07 21:57:45.000000000 +0100
@@ -204,6 +204,7 @@
uint target, uint lun);
extern void scsi_remove_device(struct scsi_device *);
extern int scsi_device_cancel(struct scsi_device *, int);
+extern void scsi_device_reprobe(struct scsi_device *);
extern int scsi_device_get(struct scsi_device *);
extern void scsi_device_put(struct scsi_device *);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-03-14 22:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-14 0:52 [PATCH ] drivers/scsi/scsi.c - export reprobe Moore, Eric
2006-03-14 15:35 ` Greg KH
2006-03-14 16:08 ` Christoph Hellwig
2006-03-14 16:31 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2006-03-14 16:18 Moore, Eric
2006-03-14 22:02 Moore, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox