From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932517AbWCNV5i (ORCPT ); Tue, 14 Mar 2006 16:57:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932528AbWCNV5i (ORCPT ); Tue, 14 Mar 2006 16:57:38 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:10763 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932517AbWCNV5h (ORCPT ); Tue, 14 Mar 2006 16:57:37 -0500 Date: Tue, 14 Mar 2006 22:57:36 +0100 From: Adrian Bunk To: "Jun'ichi Nomura" Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, Greg KH , maule@sgi.com, Andrew Morton Subject: Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register Message-ID: <20060314215736.GV13973@stusta.de> References: <44172F0E.6070708@ce.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44172F0E.6070708@ce.jp.nec.com> User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 14, 2006 at 04:01:02PM -0500, Jun'ichi Nomura wrote: > Hello, > > In 2.6.16-rc6-mm1, I've seen tons of compiler warnings on ia64: > > include2/asm/msi.h: In function `ia64_msi_init': > include2/asm/msi.h:23: warning: implicit declaration of function `msi_register' > In file included from include2/asm/machvec.h:408, > from include2/asm/io.h:70, > from include2/asm/smp.h:20, > from /build/rc6/source/include/linux/smp.h:22, > > The problem is that msi_register() is used in ia64_msi_init() > without declaration. > Since ia64_msi_init() is a part of machine vector, most of files > hit this warning and may hide other important messages. >... To avoid any wrong impression: This kind of warnings isn't harmless. gcc tries to guess the prototype of the function, and if gcc guessed wrong this can cause nasty and hard to debug runtime errors. > Thanks, >... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed