From: Jon Mason <jdmason@us.ibm.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Muli Ben-Yehuda <mulix@mulix.org>, Andi Kleen <ak@suse.de>,
Jon Mason <jdmason@us.ibm.com>, Muli Ben-Yehuda <MULI@il.ibm.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH RFC 2/3] x86-64: Calgary IOMMU - Calgary specific bits
Date: Tue, 14 Mar 2006 18:55:15 -0600 [thread overview]
Message-ID: <20060315005514.GD7699@us.ibm.com> (raw)
In-Reply-To: <20060314230306.GB1579@elf.ucw.cz>
On Wed, Mar 15, 2006 at 12:03:06AM +0100, Pavel Machek wrote:
> Hi!
>
> > +union tce_entry {
> > + u64 te_word;
> > + struct {
> > + unsigned int read :1; /* read allowed */
> > + unsigned int write :1; /* write allowed */
> > + unsigned int hubid :6; /* hub id - unused */
> > + unsigned int rsvd :4; /* reserved */
> > + unsigned long rpn :36; /* Real page number */
> > + unsigned int unused :16; /* unused */
> > + } bits;
> > +};
>
> I'd say this is going to be pretty flakey.
Why do you think this would be flakey? It's nearly identical to the
tce_entry definition in include/asm-powerpc/tce.h (endien swapped, of
course).
Thanks,
Jon
>
> Pavel
>
> --
> 161: {
next prev parent reply other threads:[~2006-03-15 0:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-14 8:24 [RFC PATCH 1/3] x86-64: Calgary IOMMU - introduce iommu_detected Muli Ben-Yehuda
2006-03-14 8:25 ` [PATCH RFC 2/3] x86-64: Calgary IOMMU - Calgary specific bits Muli Ben-Yehuda
2006-03-14 8:26 ` [RFC PATCH 3/3] x86-64: Calgary IOMMU - hook it in Muli Ben-Yehuda
2006-03-14 23:03 ` Pavel Machek
2006-03-14 23:22 ` Jon Mason
2006-03-14 23:26 ` Pavel Machek
2006-03-15 0:06 ` Jon Mason
2006-03-15 1:38 ` Muli Ben-Yehuda
2006-03-14 23:03 ` [PATCH RFC 2/3] x86-64: Calgary IOMMU - Calgary specific bits Pavel Machek
2006-03-15 0:55 ` Jon Mason [this message]
2006-03-15 0:56 ` Olof Johansson
2006-03-15 1:27 ` Jon Mason
2006-03-15 3:18 ` Olof Johansson
2006-03-15 1:52 ` Muli Ben-Yehuda
2006-03-14 15:01 ` [RFC PATCH 1/3] x86-64: Calgary IOMMU - introduce iommu_detected Andi Kleen
2006-03-14 15:07 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315005514.GD7699@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=MULI@il.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox