Re: [patch 1/1] consolidate TRUE and FALSE

Anton Altaparmakov
2006-03-16T16:40:51Z

On Thu, 16 Mar 2006, Christoph Hellwig wrote:
> On Thu, Mar 16, 2006 at 08:29:51AM -0800, Randy.Dunlap wrote:
> > On Thu, 16 Mar 2006 16:01:30 +0000 Christoph Hellwig wrote:
> >
> > > > The patch implements TRUE and FALSE in include/linux/kernel.h and removes all
> > > > the private versions.
> > > >
> > > > The patch also kills off a few private implementations of NULL.
> > >
> > > NACK. Just kill them all and use 0/1

NACK to your NACK. (-;

> > nah, the only place that using symbolic names for true and false
> > is a problem is when someone #defines or enums them bassackwards.
>
> it makes the code longer and harder to read.

I could not disagree more. It does _exactly_ the opposite. It makes the
code much easier to read but obviously you perceive it differently... I
guess it is very much a matter of taste rather than anything else.

For me, black and white is much simpler than shades of grey and whilst you
can emulate black and white with shades of grey it is still more effort to
parse than true black and white.

Certainly I refuse to have my booleans (in the kernel or anywhere else)
converted to 0 and 1 but I am all for unifying to a single boolean type
across the kernel, so this patch gets a big ACK from me.

Best regards,

Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/