From: Greg KH <gregkh@suse.de>
To: Grant Grundler <iod00d@hp.com>
Cc: Mark Maule <maule@sgi.com>,
"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
shaohua.li@intel.com
Subject: Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
Date: Thu, 16 Mar 2006 15:49:06 -0800 [thread overview]
Message-ID: <20060316234906.GA24675@suse.de> (raw)
In-Reply-To: <20060316234118.GB9746@esmail.cup.hp.com>
On Thu, Mar 16, 2006 at 03:41:18PM -0800, Grant Grundler wrote:
> On Thu, Mar 16, 2006 at 12:19:34PM -0600, Mark Maule wrote:
> > If there's objectins to having struct msi_ops declared in pci.h, then I guess
> > we need to come up with another solution.
>
> There are other transaction based interrupt subsystems that are typically
> arch specific (e.g. GSC device interrupts on PA-RISC). So far, MSI is the
> only generic one and that is clearly part of the PCI spec.
Yes, that's fine. But the core pci msi structures do not need to be
exported for the whole kernel to see, right? That's my only point here.
pci.h is cluttered enough as it is :)
thanks,
greg k-h
next prev parent reply other threads:[~2006-03-16 23:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-14 21:01 [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register Jun'ichi Nomura
2006-03-14 21:45 ` Andrew Morton
2006-03-14 21:59 ` Greg KH
2006-03-14 22:25 ` Matthew Wilcox
2006-03-15 0:51 ` Jun'ichi Nomura
2006-03-15 23:55 ` Greg KH
2006-03-16 15:19 ` Jun'ichi Nomura
2006-03-16 18:19 ` Mark Maule
2006-03-16 19:32 ` Jun'ichi Nomura
2006-03-16 19:41 ` Mark Maule
2006-03-16 23:28 ` Greg KH
2006-03-16 23:37 ` Roland Dreier
2006-03-16 23:45 ` Grant Grundler
2006-03-16 23:47 ` Greg KH
2006-03-16 23:41 ` Grant Grundler
2006-03-16 23:49 ` Greg KH [this message]
2006-03-17 0:41 ` Grant Grundler
2006-03-17 1:18 ` Mark Maule
2006-03-16 15:29 ` Jun'ichi Nomura
2006-03-14 21:57 ` Adrian Bunk
2006-03-14 23:55 ` Jun'ichi Nomura
2006-03-15 0:09 ` Mark Maule
2006-03-15 1:04 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316234906.GA24675@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=iod00d@hp.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maule@sgi.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox