public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, ak@suse.de, gregkh@suse.de,
	Dave Hansen <haveblue@us.ibm.com>
Subject: [PATCH] i386: run BIOS PCI detection before direct
Date: Thu, 16 Mar 2006 16:03:03 -0800	[thread overview]
Message-ID: <20060317000303.13252107@localhost.localdomain> (raw)


from 2.6.16-rc3-mm1 through at least 2.6.16-rc6-mm1 a patch from
Andi Kleen, titled

        x86_64-i386-pci-ordering.patch

which is now called:

	gregkh-pci-pci-give-pci-config-access-initialization-a-defined-ordering.patch

has caused a 4-way PIII Xeon (non-NUMA) to stop detecting its SCSI
card.  I believe this is also the issue keeping -mm from booting
on "elm3b67" from http://test.kernel.org/. 

The following patch reverts the ordering of the PCI detection code
to always run the BIOS initialization, first.  As far as I can
tell, this was the original behavior, and it makes my machine boot
again.

Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
---

 work-dave/arch/i386/pci/init.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff -puN arch/i386/pci/init.c~run-bios-first-take2 arch/i386/pci/init.c
--- work/arch/i386/pci/init.c~run-bios-first-take2	2006-03-16 15:55:00.000000000 -0800
+++ work-dave/arch/i386/pci/init.c	2006-03-16 15:55:47.000000000 -0800
@@ -12,13 +12,13 @@ static __init int pci_access_init(void)
 #endif
 	if (raw_pci_ops)
 		return 0;
-#ifdef CONFIG_PCI_DIRECT
-	pci_direct_init();
+#ifdef CONFIG_PCI_BIOS
+	pci_pcbios_init();
 #endif
 	if (raw_pci_ops)
 		return 0;
-#ifdef CONFIG_PCI_BIOS
-	pci_pcbios_init();
+#ifdef CONFIG_PCI_DIRECT
+	pci_direct_init();
 #endif
 	return 0;
 }
_

             reply	other threads:[~2006-03-17  0:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-17  0:03 Dave Hansen [this message]
2006-03-17 10:38 ` [PATCH] i386: run BIOS PCI detection before direct Andy Whitcroft
2006-03-22 13:10   ` Andi Kleen
2006-03-22 22:08     ` Greg KH
2006-03-22 21:37       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060317000303.13252107@localhost.localdomain \
    --to=haveblue@us.ibm.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox