From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org, "Li,
Shaohua" <shaohua.li@intel.com>,
bryce@osdl.org
Subject: Re: [PATCH] Check for online cpus before bringing them up
Date: Fri, 17 Mar 2006 19:29:48 +0530 [thread overview]
Message-ID: <20060317135948.GA27325@in.ibm.com> (raw)
In-Reply-To: <20060317042154.A13530@unix-os.sc.intel.com>
On Fri, Mar 17, 2006 at 04:21:54AM -0800, Ashok Raj wrote:
> Should we add !cpu_present(cpu) check as well just to be consistent with checks
> in cpu_up() ? Probably better if we can move smp_prepare_cpu() to within cpu_up()?
>
> How does the attached patch look.
I think this is much better (except for a minot nit - see below).
[snip]
> @@ -49,7 +49,9 @@ void enable_nonboot_cpus(void)
>
> printk("Thawing cpus ...\n");
> for_each_cpu_mask(cpu, frozen_cpus) {
> + lock_cpu_hotplug();
> error = smp_prepare_cpu(cpu);
> + unlock_cpu_hotplug();
Can we remove this smp_prepare_cpu call also (since it is being called
in cpu_up() now in your patch)?
--
Regards,
vatsa
prev parent reply other threads:[~2006-03-17 13:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 17:44 [PATCH] Check for online cpus before bringing them up Srivatsa Vaddagiri
2006-03-17 1:08 ` Andrew Morton
2006-03-17 1:16 ` Shaohua Li
2006-03-17 8:46 ` Srivatsa Vaddagiri
2006-03-17 9:04 ` Andrew Morton
2006-03-17 14:13 ` Srivatsa Vaddagiri
2006-03-18 14:09 ` Ashok Raj
2006-03-21 1:08 ` Shaohua Li
2006-03-21 1:25 ` Ashok Raj
2006-03-21 1:36 ` Shaohua Li
2006-10-06 23:10 ` Status on CPU hotplug issues Bryce Harrington
2006-10-06 23:29 ` Andrew Morton
2006-10-07 0:00 ` Bryce Harrington
2006-10-07 10:35 ` Pavel Machek
2006-10-07 20:42 ` Bryce Harrington
2006-10-08 18:29 ` Heiko Carstens
2006-10-08 19:14 ` Pavel Machek
2006-10-11 1:08 ` [BUG] 2.6.19-rc1-mm1: fs/file.c138 on ia64 Bryce Harrington
2006-10-11 1:15 ` Andrew Morton
2006-10-11 5:38 ` Bryce Harrington
2006-10-07 10:24 ` Status on CPU hotplug issues Pavel Machek
2006-10-07 20:25 ` Bryce Harrington
2006-10-08 19:13 ` Pavel Machek
2006-10-09 7:42 ` Bryce Harrington
2006-10-07 21:57 ` Pavel Machek
2006-10-09 21:40 ` Randy Dunlap
2006-10-23 22:26 ` Bryce Harrington
2006-11-08 5:35 ` Randy Dunlap
2006-11-08 5:52 ` Bryce Harrington
2006-03-17 12:21 ` [PATCH] Check for online cpus before bringing them up Ashok Raj
2006-03-17 13:59 ` Srivatsa Vaddagiri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317135948.GA27325@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=bryce@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox