From: "John W. Linville" <linville@tuxdriver.com>
To: Andreas Happe <andreashappe@snikt.net>, Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, jgarzik@pobox.com,
netdev@vger.kernel.org, zhu.yi@intel.com
Subject: Re: 2.6.16-rc5-mm2: IPW_QOS: two remarks
Date: Fri, 17 Mar 2006 14:14:52 -0500 [thread overview]
Message-ID: <20060317191447.GC21830@tuxdriver.com> (raw)
In-Reply-To: <20060307170642.GE3974@stusta.de> <200603050146.27529.andreashappe@snikt.net>
On Sun, Mar 05, 2006 at 01:46:26AM +0100, Andreas Happe wrote:
> Add the following config entries for the ipw2200 driver to
> drivers/net/wireless/Kconfig
> * IPW2200_MONITOR
> enables Monitor mode, as this seems to generate lots of firmware errors
> it depends upon BROKEN
> * IPW2200_QOS
> enables QoS feature - this is under development right now, so it depends
> upon EXPERIMENTAL.
Your patch appears to be whitespace-damaged. Please configure your
mailer appropriately.
Also, please stick to the patch format described here:
http://linux.yyz.us/patch-format.html
In particular, don't put anything in the message that doesn't belong
in the kernel's changelog, such as email-ish messages.
On Tue, Mar 07, 2006 at 06:06:42PM +0100, Adrian Bunk wrote:
> On Sun, Mar 05, 2006 at 01:46:26AM +0100, Andreas Happe wrote:
> > On Friday 03 March 2006 16:26, Adrian Bunk wrote:
> >...
> > > - please add a help text
> >
> > i could add some stuff about WMM to its help text, but I think someone more
> > involved with the ipw2200-project should do that.
>
> Even a short help text is better than no help text.
I agree w/ Adrian. Since you are touching it, please put something
appropriate in the Kconfig file. Zhu Yi may be able to help if you
aren't sure what the help text should say.
Thanks!
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-03-17 19:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 12:56 2.6.16-rc5-mm2 Andrew Morton
2006-03-03 15:26 ` 2.6.16-rc5-mm2: IPW_QOS: two remarks Adrian Bunk
2006-03-05 0:46 ` Andreas Happe
2006-03-07 17:06 ` Adrian Bunk
2006-03-17 19:14 ` John W. Linville [this message]
2006-03-18 17:47 ` [PATCH 2.6.16-rc6 1/1] ipw2200: Add Kconfig entries for QOS and Monitor mode Andreas Happe
2006-03-22 3:11 ` Zhu Yi
2006-03-03 16:08 ` 2.6.16-rc5-mm2 (mips compile fix) Jason Baron
2006-03-03 17:08 ` 2.6.16-rc5-mm2 Benoit Boissinot
2006-03-04 1:34 ` 2.6.16-rc5-mm2 Grant Coady
2006-03-05 6:26 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-05 7:24 ` 2.6.16-rc5-mm2 Mike Galbraith
2006-03-06 11:35 ` 2.6.16-rc5-mm2 Takashi Iwai
2006-03-05 12:34 ` 2.6.16-rc5-mm2 Antonino A. Daplas
2006-03-04 12:14 ` [-mm patch] drivers/acpi/bus.c: make struct acpi_sci_dir static Adrian Bunk
2006-03-04 12:14 ` [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static Adrian Bunk
2006-03-04 12:14 ` [RFC: -mm patch] drivers/message/fusion/mptbase.c: make mpt_read_ioc_pg_3() static Adrian Bunk
2006-03-04 12:14 ` [-mm patch] kernel/futex.c: make futexfs_get_sb() static again Adrian Bunk
2006-03-06 14:44 ` David Howells
2006-03-04 12:14 ` [-mm patch] mm/bootmem.c: make bdata_list static Adrian Bunk
2006-03-04 12:14 ` [-mm patch] NFS: make 2 functions static Adrian Bunk
2006-03-04 12:14 ` [RFC: -mm patch] fs/locks.c: make posix_locks_deadlock() static Adrian Bunk
2006-03-04 17:29 ` 2.6.16-rc5-mm2 Mattia Dongili
2006-03-05 6:28 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-05 8:14 ` 2.6.16-rc5-mm2 Benoit Boissinot
2006-03-05 8:34 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-05 11:42 ` 2.6.16-rc5-mm2 Stefan Rompf
2006-03-06 15:22 ` 2.6.16-rc5-mm2 James Ketrenos
2006-03-05 22:54 ` 2.6.16-rc5-mm2 Dominik Karall
2006-03-07 5:43 ` 2.6.16-rc5-mm2 Andrew Morton
2006-03-07 10:43 ` 2.6.16-rc5-mm2 David Howells
2006-03-07 14:33 ` 2.6.16-rc5-mm2 Dominik Karall
2006-03-07 17:25 ` 2.6.16-rc5-mm2 john stultz
2006-03-08 1:13 ` 2.6.16-rc5-mm2 Andi Kleen
2006-03-06 8:45 ` 2.6.16-rc5-mm2 Cornelia Huck
2006-03-06 9:10 ` 2.6.16-rc5-mm2 compile error in urb.c Helge Hafting
2006-03-06 9:21 ` Andrew Morton
2006-03-06 12:17 ` Helge Hafting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317191447.GC21830@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akpm@osdl.org \
--cc=andreashappe@snikt.net \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhu.yi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox