From: Pavel Machek <pavel@ucw.cz>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Matt_Domsch@dell.com, matthew.e.tolentino@intel.com,
linux-kernel@vger.kernel.org,
mactel-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH] - make sure that EFI variable data size is always 64 bit
Date: Mon, 20 Mar 2006 09:54:12 +0100 [thread overview]
Message-ID: <20060320085412.GA1772@elf.ucw.cz> (raw)
In-Reply-To: <20060319184325.GA7605@srcf.ucam.org>
On Ne 19-03-06 18:43:25, Matthew Garrett wrote:
> The EFI spec states that the data size of an EFI variable is 64 bits.
> "unsigned long", on the other hand, isn't on IA32.
>
> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> index bda5bce..488c24c 100644
> --- a/drivers/firmware/efivars.c
> +++ b/drivers/firmware/efivars.c
> @@ -110,7 +110,7 @@ static LIST_HEAD(efivar_list);
> struct efi_variable {
> efi_char16_t VariableName[1024/sizeof(efi_char16_t)];
> efi_guid_t VendorGuid;
> - unsigned long DataSize;
> + __u64 DataSize;
> __u8 Data[1024];
> efi_status_t Status;
> __u32 Attributes;
Please, use u64 (not __u64).
Pavel
--
86: {
prev parent reply other threads:[~2006-03-20 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 18:43 [PATCH] - make sure that EFI variable data size is always 64 bit Matthew Garrett
2006-03-19 21:29 ` Matt Domsch
2006-03-19 21:33 ` Matthew Garrett
2006-03-19 22:49 ` Matt Domsch
2006-03-19 23:17 ` Matthew Garrett
2006-03-20 8:54 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060320085412.GA1772@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=Matt_Domsch@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mactel-linux-devel@lists.sourceforge.net \
--cc=matthew.e.tolentino@intel.com \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox