From: Matthew Wilcox <matthew@wil.cx>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: DoS with POSIX file locks?
Date: Mon, 20 Mar 2006 05:39:50 -0700 [thread overview]
Message-ID: <20060320123950.GF8980@parisc-linux.org> (raw)
In-Reply-To: <E1FLJLs-00085u-00@dorka.pomaz.szeredi.hu>
On Mon, Mar 20, 2006 at 01:19:12PM +0100, Miklos Szeredi wrote:
> > > Unlike open files there doesn't seem to be any limit on the number of
> > > locks being held either globally or by a single process.
> >
> > RLIMIT_LOCKS
>
> Which is not actually used anywhere.
Right. Um. I took it out back in March 2003 after enough people
convinced me it wasn't worth trying to account for all the memory
processes use, and the userbeans project would take care of it anyway.
Haha.
It's hard to fix the accounting. You have to deal with one thread
allocating the lock, and then a different thread freeing it. We never
actually accounted for posix locks (which are the ones we really needed
to!) and on occasion had current->locks go negative, with all kinds of
associated badness.
So you're welcome to try and fix it, but you may well go mad doing so.
Fortunately, I'm no longer maintaining locks.c, but I'd be happy to
answer questions.
next prev parent reply other threads:[~2006-03-20 12:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 11:41 DoS with POSIX file locks? Miklos Szeredi
2006-03-20 12:11 ` Matthew Wilcox
2006-03-20 12:19 ` Miklos Szeredi
2006-03-20 12:39 ` Matthew Wilcox [this message]
2006-03-20 12:52 ` Miklos Szeredi
2006-03-20 13:13 ` Arjan van de Ven
2006-03-20 13:24 ` Miklos Szeredi
2006-03-20 13:30 ` Arjan van de Ven
2006-03-20 13:39 ` Miklos Szeredi
2006-03-20 15:32 ` Matthew Wilcox
2006-03-20 16:41 ` Miklos Szeredi
2006-03-20 20:35 ` J. Bruce Fields
2006-03-21 6:38 ` Miklos Szeredi
2006-03-20 18:22 ` Trond Myklebust
2006-03-21 9:44 ` Miklos Szeredi
2006-03-21 17:28 ` Trond Myklebust
2006-03-21 17:58 ` Miklos Szeredi
2006-03-21 18:16 ` Trond Myklebust
2006-03-21 19:16 ` Chris Wright
2006-03-22 6:21 ` Miklos Szeredi
2006-03-22 11:12 ` Trond Myklebust
2006-03-22 12:16 ` Miklos Szeredi
2006-03-22 15:56 ` Trond Myklebust
2006-03-22 16:34 ` Miklos Szeredi
2006-03-22 20:07 ` Trond Myklebust
2006-03-22 20:19 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060320123950.GF8980@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox