Re: [PATCH 117/141] V4L/DVB (3390): Fix module parameters

Edgar Toernig
2006-03-20T19:11:09Z

Duncan Sands wrote:
>
> > -module_param(dvb_override_tune_delay, int, 0444);
> > +module_param(dvb_override_tune_delay, int, 0644);
>
> if (dvb_override_tune_delay > 0)
> fepriv->min_delay = (dvb_override_tune_delay * HZ) / 1000;
>
> I guess the value of dvb_override_tune_delay could change from non-zero
> to zero between testing the condition and setting min_delay.

This is within an ioctl and thus protected by the big kernel lock.

Ciao, ET.