From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Luke Yang <luke.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Blackfin serial driver for kernel 2.6.16
Date: Tue, 21 Mar 2006 07:54:25 +0000 [thread overview]
Message-ID: <20060321075425.GB21287@flint.arm.linux.org.uk> (raw)
In-Reply-To: <489ecd0c0603202345x1e12ea64y248baabc939965e6@mail.gmail.com>
On Tue, Mar 21, 2006 at 03:45:57PM +0800, Luke Yang wrote:
> On 3/20/06, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > On Mon, Mar 20, 2006 at 06:07:44PM +0800, Luke Yang wrote:
> > > Index: git/linux-2.6/drivers/serial/bfin_serial_5xx.c
> > > ===================================================================
> > > --- /dev/null
> > > +++ linux-2.6/drivers/serial/bfin_serial_5xx.c
> >
> > Please convert this driver to use the serial_core infrastructure. Thanks.
> Thank you! This is a driver based on the 68328 serial driver. Do
> you mean every serial driver must follow the serial core framework? If
> so, we'll change it ASAP. For now, my previous blackfin architecture
> patch needs this driver to get compiled.
It is preferable since it massively reduces code duplication, and fixes
various minor issues found in the original serial driver.
As a result, it improves code maintainability since a fix to the semantics
of the serial layer will fix all drivers, instead of having to apply the
same fix to multiple serial drivers (which just doesn't happen.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2006-03-21 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 10:07 [PATCH 2/2] Blackfin serial driver for kernel 2.6.16 Luke Yang
2006-03-20 10:24 ` Russell King
2006-03-21 7:45 ` Luke Yang
2006-03-21 7:54 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060321075425.GB21287@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox