Re: [3/3 PATCH] Kprobes: User space probes support- single stepping out-of-line

Arjan van de Ven
2006-03-20T11:24:53Z

> And we'll need to actually *be* in-atomic. That means we need an
> open-coded inc_preempt_count() and dec_preempt_count() in there and I don't
> see them.
>

..

> Why is VM_LOCKED being set? (It needs a comment).
>
> Where does it get unset?

if this is an attempt to make the copy_in_atomic to be atomic, then it
is a bug; the user can unset this bit after all via mprotect, even from
another thread, and concurrently. UnGood(tm).