public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Sasa Ostrouska <sasa.ostrouska@volja.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: p4-clockmod not working in 2.6.16
Date: Tue, 21 Mar 2006 17:01:15 -0500	[thread overview]
Message-ID: <20060321220115.GA8583@redhat.com> (raw)
In-Reply-To: <1142978230.3470.12.camel@localhost>

On Tue, Mar 21, 2006 at 10:57:10PM +0100, Sasa Ostrouska wrote:

 > Hi Dave, here it is, this is on a Sony Vaio PCG-GRT816S laptop:
 > CPU0: Temperature above threshold
 > CPU0: Running in modulated clock mode
 > .. ad infinitum ..

*yowch*.  Are you running that CPU fanless or something?

Does the patch below help?

		Dave


Fix the code to disable freqs less than 2GHz in N60 errata.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Dave Jones <davej@redhat.com>

Index: linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c
===================================================================
--- linux-2.6.15.orig/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c
+++ linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c
@@ -244,7 +244,7 @@ static int cpufreq_p4_cpu_init(struct cp
 	for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) {
 		if ((i<2) && (has_N44_O17_errata[policy->cpu]))
 			p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID;
-		else if (has_N60_errata[policy->cpu] && p4clockmod_table[i].frequency < 2000000)
+		else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000)
 			p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID;
 		else
 			p4clockmod_table[i].frequency = (stock_freq * i)/8;

-- 
http://www.codemonkey.org.uk

  parent reply	other threads:[~2006-03-21 22:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-21 20:55 p4-clockmod not working in 2.6.16 Sasa Ostrouska
2006-03-21 21:01 ` Dave Jones
2006-03-21 21:57   ` Sasa Ostrouska
2006-03-21 21:59     ` Arjan van de Ven
2006-03-21 22:52       ` Sasa Ostrouska
2006-03-21 22:01     ` Dave Jones [this message]
2006-03-21 22:08       ` Sasa Ostrouska
2006-03-21 22:13       ` Sasa Ostrouska
2006-03-21 22:20         ` Dave Jones
2006-03-21 22:51           ` Sasa Ostrouska
2006-03-22  5:57       ` Edgar Toernig
2006-03-22  6:20         ` Mike Galbraith
     [not found]           ` <1144147663.2588.247.camel@elsdt-scarecrow.arc.com>
2006-04-05 12:02             ` Tim Phipps
     [not found]               ` <1144245205.7571.11.camel@homer>
2006-04-05 13:59                 ` Mike Galbraith
2006-04-13 12:20                   ` Tim Phipps
2006-04-13 12:42                     ` Jesper Juhl
2006-04-13 13:59                       ` [PATCH 001/001] cpufreq: p4_clockmod errata N60 handling is over zealous Tim Phipps

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060321220115.GA8583@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasa.ostrouska@volja.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox