Re: [PATCH 1/2]Blackfin archtecture patche for 2.6.16

[Andrew Morton <akpm@osdl.org>]

Robin Getz <rgetz@blackfin.uclinux.org> wrote:
>
> Luke Yang wrote:
> >On 3/21/06, Andrew Morton <akpm@osdl.org> wrote:
> > > - How widespread/popular is the blackfin?  Are many devices using it?
> > >   How old/mature is it?  Is it a new thing or is it near end-of-life?
> >   As a DSP, Blackfin has been there for years and is somewhat popular.
> >But as a CPU which can run Linux, we are trying to make it popular.
> >Anyway a 5$ chip runs Linux and can do audio/video codec is a good toy to 
> >play with.
> 
> I would not describe it as a toy (sorry Luke),
>
> [ interesting info ]
>

Thanks.

> If you think our patch sucks, fine - let us know where to fix it.

It looks reasonable to me, from a ten-minute-scan.

Well.  All architecture ports suck.  Yours sucks averagely ;)

The todo list of which I'm aware is

- use serial core in that driver

- Fix up that ioctl so it a) doesn't sleep in spinlock and b) compiles

- Use generic IRQ framework

- Review all the volatiles, consolidate them in some helper-in-header-file.

- Sort out maintainance issues, gather signed-off-bys. (Done, it appears)

More things might come out once people start paying more attention, but if
that's the extent of things, I'd be OK with a merge when you're ready.