Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3)

Christoph Lameter
2006-03-22T01:35:38Z

On Wed, 22 Mar 2006, Jesper Juhl wrote:

> Fix memory leak in mm/slab.c::alloc_kmemlist().
> If one allocation fails we have to roll-back all allocations made up to the
> point of failure.

Sorry but you cannot roll back. alloc_kmemlist() could have been used for
tuning the cpucache while accesses to the slab continue. "Rolling back"
would partially destroy the slab for some nodes and likely cause the
system to crash. We can only roll back if this is actually an initial
allocation and we are assured that the whole thing is not yet in use.