public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] kernel/time.c: remove unused pps_* variables
Date: Wed, 22 Mar 2006 11:40:59 +0100	[thread overview]
Message-ID: <20060322104059.GA3771@stusta.de> (raw)
In-Reply-To: <20060318044056.350a2931.akpm@osdl.org>

On Sat, Mar 18, 2006 at 04:40:56AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc6-mm1:
>...
> -kernel-timec-remove-unused-pps_-variables.patch
> 
>  Dropped - being redone.
>...

This patch was unrelated, but seems to have been dropped due to context 
changes.

A version that applies against 2.6.16-rc6-mm2 is below.

cu
Adrian


<--  snip  -->


From: Adrian Bunk <bunk@stusta.de>

AFAIR there is a patch floating around that might use these variables, 
but this patch is still unmerged and my patch can easily be undone.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/linux/timex.h |    8 --------
 kernel/time.c         |   23 ++++++-----------------
 2 files changed, 6 insertions(+), 25 deletions(-)

--- linux-2.6.16-rc6-mm2-full/include/linux/timex.h.old	2006-03-21 23:30:45.000000000 +0100
+++ linux-2.6.16-rc6-mm2-full/include/linux/timex.h	2006-03-21 23:31:20.000000000 +0100
@@ -247,19 +247,11 @@
 extern long time_next_adjust;	/* Value for time_adjust at next tick */
 
 /* interface variables pps->timer interrupt */
-extern long pps_offset;		/* pps time offset (us) */
 extern long pps_jitter;		/* time dispersion (jitter) (us) */
 extern long pps_freq;		/* frequency offset (scaled ppm) */
 extern long pps_stabil;		/* frequency dispersion (scaled ppm) */
 extern long pps_valid;		/* pps signal watchdog counter */
 
-/* interface variables pps->adjtimex */
-extern int pps_shift;		/* interval duration (s) (shift) */
-extern long pps_jitcnt;		/* jitter limit exceeded */
-extern long pps_calcnt;		/* calibration intervals */
-extern long pps_errcnt;		/* calibration errors */
-extern long pps_stbcnt;		/* stability limit exceeded */
-
 /**
  * ntp_clear - Clears the NTP state variables
  *
--- linux-2.6.16-rc6-mm2-full/kernel/time.c.old	2006-03-21 23:30:57.000000000 +0100
+++ linux-2.6.16-rc6-mm2-full/kernel/time.c	2006-03-21 23:31:58.000000000 +0100
@@ -202,7 +202,6 @@
 	return do_sys_settimeofday(tv ? &new_ts : NULL, tz ? &new_tz : NULL);
 }
 
-long pps_offset;		/* pps time offset (us) */
 long pps_jitter = MAXTIME;	/* time dispersion (jitter) (us) */
 
 long pps_freq;			/* frequency offset (scaled ppm) */
@@ -210,16 +209,6 @@
 
 long pps_valid = PPS_VALID;	/* pps signal watchdog counter */
 
-int pps_shift = PPS_SHIFT;	/* interval duration (s) (shift) */
-
-long pps_jitcnt;		/* jitter limit exceeded */
-long pps_calcnt;		/* calibration intervals */
-long pps_errcnt;		/* calibration errors */
-long pps_stbcnt;		/* stability limit exceeded */
-
-/* hook for a loadable hardpps kernel module */
-void (*hardpps_ptr)(struct timeval *);
-
 /* we call this to notify the arch when the clock is being
  * controlled.  If no such arch routine, do nothing.
  */
@@ -315,7 +304,7 @@
 		else if ( time_status & (STA_PLL | STA_PPSTIME) ) {
 		    ltemp = (time_status & (STA_PPSTIME | STA_PPSSIGNAL)) ==
 		            (STA_PPSTIME | STA_PPSSIGNAL) ?
-		            pps_offset : txc->offset;
+		            0 : txc->offset;
 
 		    /*
 		     * Scale the phase adjustment and
@@ -390,12 +379,12 @@
 	txc->tick	   = tick_usec;
 	txc->ppsfreq	   = pps_freq;
 	txc->jitter	   = pps_jitter >> PPS_AVG;
-	txc->shift	   = pps_shift;
+	txc->shift	   = 0;
 	txc->stabil	   = pps_stabil;
-	txc->jitcnt	   = pps_jitcnt;
-	txc->calcnt	   = pps_calcnt;
-	txc->errcnt	   = pps_errcnt;
-	txc->stbcnt	   = pps_stbcnt;
+	txc->jitcnt	   = 0;
+	txc->calcnt	   = 0;
+	txc->errcnt	   = 0;
+	txc->stbcnt	   = 0;
 	write_sequnlock_irq(&xtime_lock);
 	do_gettimeofday(&txc->time);
 	notify_arch_cmos_timer();


  parent reply	other threads:[~2006-03-22 10:41 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-18 12:40 2.6.16-rc6-mm2 Andrew Morton
2006-03-18 15:10 ` sata_mv success on 2.6.16-rc6-mm2 (was: Re: 2.6.16-rc6-mm2) Sander
2006-03-18 17:25 ` 2.6.16-rc6-mm2: new RDMA CM EXPORT_SYMBOL's Adrian Bunk
2006-03-19  1:44   ` Tom Tucker
2006-03-19  1:57     ` Lee Revell
2006-03-18 18:45 ` [-mm patch] drivers/edac/e752x_edac.c: make sysbus_message static Adrian Bunk
2006-03-18 18:45 ` [-mm patch] drivers/scsi/aic7xxx/aic79xx_core.c: make ahd_match_scb() static Adrian Bunk
2006-03-18 18:45 ` [-mm patch] nfs4proc.c: make _nfs4_proc_setclientid_confirm() static Adrian Bunk
2006-03-18 18:45 ` [-mm patch] net/core/scm.c: make scm_detach_fds() static Adrian Bunk
2006-03-18 20:21 ` 2.6.16-rc6-mm2 Rafael J. Wysocki
2006-03-18 20:54   ` 2.6.16-rc6-mm2 Andrew Morton
2006-03-18 21:24     ` 2.6.16-rc6-mm2 Rafael J. Wysocki
2006-03-18 21:25     ` Emulex IP over FC support shogunx
2006-03-19 23:03     ` 2.6.16-rc6-mm2 - BUG when flushing a ramdisk Neil Brown
2006-03-19  1:09 ` 2.6.16-rc6-mm2 uninitialized online_policy_cpus.bits[0] Con Kolivas
2006-03-19  1:29   ` Con Kolivas
2006-03-19  1:35   ` Andrew Morton
2006-03-19  2:37     ` Con Kolivas
2006-03-19  6:13     ` Venkatesh Pallipadi
2006-03-20  3:26 ` New Areca driver in 2.6.16-rc6-mm2 Dax Kelson
2006-03-21 23:49   ` Chris Caputo
2006-03-22  3:37     ` Matti Aarnio
2006-03-22  3:56       ` Randy.Dunlap
2006-03-22  3:56         ` Al Viro
2006-03-22  4:41       ` erich
2006-03-20 13:02 ` RAID5 grow success (was: Re: 2.6.16-rc6-mm2) Sander
2006-03-20 13:33 ` Some sata_mv error messages " Sander
2006-03-21  1:02   ` Some sata_mv error messages Jeff Garzik
2006-03-21  2:25     ` Dave Jones
2006-03-21  2:35       ` Jeff Garzik
2006-03-21 16:06         ` Peter Jones
2006-03-21  4:48     ` Mark Lord
2006-03-21  7:28       ` Sander
2006-03-21 19:33       ` Denis Leroy
2006-03-21 19:37         ` Jeff Garzik
2006-03-21 19:42         ` Mark Lord
2006-03-21  7:26     ` Sander
2006-03-21 20:27 ` 2.6.16-rc6-mm2: reiser4 BUG when unmounting fs Laurent Riffard
2006-03-21 20:38   ` Laurent Riffard
2006-03-22  7:43     ` Vladimir V. Saveliev
2006-03-22 18:38       ` Laurent Riffard
2006-03-23 17:32       ` Alexander Gran
2006-03-21 22:54 ` 2.6.16-rc6-mm2: Why is CONFIG_MIGRATION available for everyone? Adrian Bunk
2006-03-21 22:57   ` Christoph Lameter
2006-03-21 23:40   ` Christoph Lameter
2006-03-22  8:41 ` 2.6.16-rc6-mm2 J.A. Magallon
2006-03-22  8:48   ` 2.6.16-rc6-mm2 Andrew Morton
2006-03-22 10:40 ` Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-03-04 12:15 [2.6 patch] kernel/time.c: remove unused pps_* variables Adrian Bunk
2006-02-18 13:23 Adrian Bunk
2006-02-01 20:03 [PATCH 0/5] Infiniband: connection abstraction Sean Hefty
2006-02-01 20:07 ` [PATCH 1/5] " Sean Hefty
2006-02-01 20:10 ` [PATCH 2/5] " Sean Hefty
2006-02-01 20:15 ` [PATCH 3/5] " Sean Hefty
2006-03-03 21:14   ` [PATCH 3/5] export of ip_dev_find as part of Infiniband " Sean Hefty
2006-02-01 20:18 ` [PATCH 4/5] Infiniband: " Sean Hefty
2006-02-01 20:19 ` [PATCH 5/5] " Sean Hefty
2006-03-03 21:13 ` [PATCH 0/5] " Sean Hefty
2006-03-03 22:53   ` [openib-general] " Roland Dreier
2006-03-06 18:59     ` [PATCH 1/6] IB: common handling for marshalling parameters to/from userspace Sean Hefty
2006-03-19  1:19       ` 2.6.16-rc6-mm2: new RDMA CM EXPORT_SYMBOL's Andrew Morton
2006-03-19  4:11         ` Matthew Frost
2006-03-20 18:32           ` [openib-general] " Sean Hefty
2006-03-20 18:47             ` Arjan van de Ven
2006-03-20 18:47         ` Roland Dreier
2006-03-20 19:18           ` [openib-general] " Sean Hefty
2006-03-06 19:04     ` [PATCH 2/6] IB: match connection requests based on private data Sean Hefty
2006-03-06 22:05       ` [openib-general] " Sean Hefty
2006-03-06 23:29       ` [PATCH 2/6 v2] " Sean Hefty
2006-03-06 19:07     ` [PATCH 3/6] net/IB: export ip_dev_find Sean Hefty
2006-03-06 21:31       ` Roland Dreier
2006-03-06 21:42         ` David S. Miller
2006-03-06 19:10     ` [PATCH 4/6] IB: address translation to map IP to IB addresses (GIDs) Sean Hefty
2006-03-06 23:31       ` [PATCH 4/6 v2] IB: address translation to map IP toIB " Sean Hefty
2006-03-11  1:14         ` Roland Dreier
2006-03-11  6:10           ` Sean Hefty
2006-03-21 20:57         ` Roland Dreier
2006-03-21 21:08           ` [openib-general] " Sean Hefty
2006-03-21 22:39             ` Roland Dreier
2006-03-06 19:18     ` [PATCH 5/6] IB: IP address based RDMA connection manager Sean Hefty
2006-03-06 19:21     ` [PATCH 6/6] IB: userspace support for " Sean Hefty
2006-03-06 21:33       ` Roland Dreier
2006-03-06 21:42         ` [openib-general] " Sean Hefty
2006-03-06 21:58           ` Roland Dreier
2006-03-06 22:28             ` David S. Miller
2006-03-06 22:32               ` Roland Dreier
2006-03-06 22:39                 ` David S. Miller
2006-03-06 22:41                   ` Roland Dreier
2006-03-06 22:50                     ` David S. Miller
2006-03-06 23:40                       ` Roland Dreier
2006-03-07  0:05                         ` Bryan O'Sullivan
2006-03-07  0:10                           ` Roland Dreier
2006-03-07  0:26                         ` David S. Miller
2006-03-06 21:35       ` Roland Dreier
2006-03-06 21:43         ` [openib-general] " Sean Hefty
2006-03-06 23:41       ` [PATCH 6/6 v2] " Sean Hefty
2006-03-22  1:40         ` Roland Dreier
2006-03-22  8:30           ` Michael S. Tsirkin
2006-03-22 15:18             ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060322104059.GA3771@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox