Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

Stephen Hemminger
2006-03-22T17:18:02Z

On Tue, 21 Mar 2006 22:31:14 -0800
Chris Wright <chrisw@sous-sol.org> wrote:

> The network device frontend driver allows the kernel to access network
> devices exported exported by a virtual machine containing a physical
> network device driver.
>
> Signed-off-by: Ian Pratt <ian.pratt@xensource.com>
> Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---

In addition to earlier comments:

* should handle multiple interfaces, not just one static.

* the whole notifier fake arp call back is fugly

* use sysfs instead of /proc to handle the simple rxbuf_min,max stuff or use
ethtool ring parameters

* proc module_owner not set, so ref counting not done. Moot if you switch
to sysfs.

* since you add ethtool for checksum,
why not some basic stuff like driver info and carrier state?

* xen_net_read_mac seems like it could just be put inside driver.

* minor
use free_netdev() rather than kfree in error path
don't bother initializing .next/.priority in notifier_block if it is just 0

* what about mtu change?

* what about mac address change?

* Could you support scatter gather?