Re: [RFC PATCH 16/35] subarch support for interrupt and exception gates

Chris Wright
2006-03-22T20:54:21Z

* Andi Kleen (ak@suse.de) wrote:
> On Wednesday 22 March 2006 07:30, Chris Wright wrote:
> > Abstract the code that sets up interrupt and exception gates, and
> > add a separate subarch implementation for Xen.
>
> AFAIK the only difference is that Xen uses a table of them to pass
> the hypervisor and normal Linux calls the macros directly, right?

Yes.

> I would suggest you just use the table for normal Linux too
> and make the function that processes them natively !CONFIG_XEN
> I guess it will make the code smaller for the normal case and people happy.

Hadn't considered that type of consolidation. So load_idt() would
generally be one step further from lidt insn on native, which shouldn't
be a problem. Looks like kexec would need to be taught about building
the table.

thanks,
-chris