From: Greg KH <greg@kroah.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: minyard@acm.org, Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Yani Ioannou <yani.ioannou@gmail.com>
Subject: Re: [PATCH 2/2] Add full sysfs support to the IPMI driver
Date: Wed, 22 Mar 2006 12:47:51 -0800 [thread overview]
Message-ID: <20060322204751.GC12335@kroah.com> (raw)
In-Reply-To: <1143018069.2955.43.camel@laptopd505.fenrus.org>
On Wed, Mar 22, 2006 at 10:01:09AM +0100, Arjan van de Ven wrote:
> On Tue, 2006-03-21 at 16:13 -0600, Corey Minyard wrote:
>
>
> > +static void ipmi_bmc_release(struct device *dev)
> > +{
> > + printk(KERN_DEBUG "ipmi_bmc release\n");
> > +}
>
>
> eehhhh NO.
> Please read the many comments and documentations about why a release
> function is NOT allowed to be empty. In fact the kernel warned you about
> that, didn't it?
Of course that's not ok.
Come on people, does everyone think I just put that warning message in
the kernel for fun to force you to create an empty release function?
Why do people ignore the helpful hints that the kernel provides?
I can take that check out and watch people get their code wrong even
more, as it sure doesn't seem like it is helping anyone out these
days...
Corey, haven't we discussed this in the past?
greg k-h
next prev parent reply other threads:[~2006-03-22 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 22:13 [PATCH 2/2] Add full sysfs support to the IPMI driver Corey Minyard
2006-03-22 9:01 ` Arjan van de Ven
2006-03-22 20:47 ` Greg KH [this message]
2006-03-22 20:59 ` Al Viro
2006-03-22 21:29 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060322204751.GC12335@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=yani.ioannou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox