Re: [PATCH 2/2] Add full sysfs support to the IPMI driver

Greg KH
2006-03-22T20:48:12Z

On Wed, Mar 22, 2006 at 10:01:09AM +0100, Arjan van de Ven wrote:
> On Tue, 2006-03-21 at 16:13 -0600, Corey Minyard wrote:
>
>
> > +static void ipmi_bmc_release(struct device *dev)
> > +{
> > + printk(KERN_DEBUG "ipmi_bmc release\n");
> > +}
>
>
> eehhhh NO.
> Please read the many comments and documentations about why a release
> function is NOT allowed to be empty. In fact the kernel warned you about
> that, didn't it?

Of course that's not ok.

Come on people, does everyone think I just put that warning message in
the kernel for fun to force you to create an empty release function?
Why do people ignore the helpful hints that the kernel provides?

I can take that check out and watch people get their code wrong even
more, as it sure doesn't seem like it is helping anyone out these
days...

Corey, haven't we discussed this in the past?

greg k-h