From: Greg KH <greg@kroah.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] PCIERR : interfaces for synchronous I/O error detection on driver
Date: Wed, 22 Mar 2006 13:01:57 -0800 [thread overview]
Message-ID: <20060322210157.GH12335@kroah.com> (raw)
In-Reply-To: <44210D1B.7010806@jp.fujitsu.com>
On Wed, Mar 22, 2006 at 05:38:51PM +0900, Hidetoshi Seto wrote:
> This patch proposes new interfaces, that known by few as iochk_*,
> for synchronous I/O error detection on PCI drivers.
Please include the linux-pci mailing list in further discussion of PCI
specific things.
> Index: linux-2.6.16_WORK/include/linux/pci.h
> ===================================================================
> --- linux-2.6.16_WORK.orig/include/linux/pci.h 2006-03-22
> 14:27:04.000000000 +0900
Your patch is linewrapped :(
> +++ linux-2.6.16_WORK/include/linux/pci.h 2006-03-22
> 14:41:01.000000000 +0900
> @@ -696,6 +696,21 @@
> #endif /* HAVE_ARCH_PCI_RESOURCE_TO_USER */
>
>
> +/* PCIERR_CHECK provides additional interfaces for drivers to detect
> + * some IO errors, to support drivers can handle errors properly.
> + * Some archs requiring high-reliability would implement these.
> + */
> +#ifdef HAVE_ARCH_PCIERR_CHECK
> +/* type of iocookie is arch dependent */
> +extern void pcierr_clear(iocookie *cookie, struct pci_dev *dev);
> +extern int pcierr_read(iocookie *cookie);
> +#else
> +typedef int iocookie;
> +static inline void pcierr_clear(iocookie *cookie, struct pci_dev *dev) {}
> +static inline int pcierr_read(iocookie *cookie) { return 0; }
> +#endif
We need to see the code that implements this before we can accept a
header file change.
thanks,
greg k-h
next prev parent reply other threads:[~2006-03-22 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 8:38 [PATCH] PCIERR : interfaces for synchronous I/O error detection on driver Hidetoshi Seto
2006-03-22 21:01 ` Greg KH [this message]
2006-03-24 7:47 ` [PATCH 1/6] " Hidetoshi Seto
2006-03-24 23:43 ` Linas Vepstas
2006-03-27 2:37 ` Hidetoshi Seto
2006-03-31 22:01 ` Linas Vepstas
2006-04-03 4:54 ` Hidetoshi Seto
2006-03-24 7:48 ` [PATCH 2/6] PCIERR : interfaces for synchronous I/O error detection on driver (config) Hidetoshi Seto
2006-03-24 7:49 ` [PATCH 3/6] PCIERR : interfaces for synchronous I/O error detection on driver (base) Hidetoshi Seto
2006-03-24 7:50 ` [PATCH 4/6] PCIERR : interfaces for synchronous I/O error detection on driver (mcadrv) Hidetoshi Seto
2006-03-24 7:51 ` [PATCH 5/6] PCIERR : interfaces for synchronous I/O error detection on driver (poison) Hidetoshi Seto
2006-03-24 7:52 ` [PATCH 6/6] PCIERR : interfaces for synchronous I/O error detection on driver (sample: Fusion MPT) Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060322210157.GH12335@kroah.com \
--to=greg@kroah.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox