From: Joel Becker <Joel.Becker@oracle.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Possible NULL pointer dereference in fs/configfs/dir.c
Date: Wed, 22 Mar 2006 15:57:21 -0800 [thread overview]
Message-ID: <20060322235721.GF7844@ca-server1.us.oracle.com> (raw)
In-Reply-To: <1143070614.27446.4.camel@alice>
On Thu, Mar 23, 2006 at 12:36:54AM +0100, Eric Sesterhenn wrote:
> I would then propose the following patch, so the check can be
> removed for people who like small kernels. I dont think gcc notices
> that all callers use non-NULL values and optimizes it away.
>
> - if (group && group->default_groups) {
> + BUG_ON(!group); /* group == NULL is not allowed */
> +
> + if (group->default_groups) {
This is pretty much what I meant. Thanks.
Joel
--
Life's Little Instruction Book #3
"Watch a sunrise at least once a year."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2006-03-22 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 23:05 [Patch] Possible NULL pointer dereference in fs/configfs/dir.c Eric Sesterhenn
2006-03-22 23:27 ` Joel Becker
2006-03-22 23:36 ` Eric Sesterhenn
2006-03-22 23:57 ` Joel Becker [this message]
2006-03-25 16:59 ` Adrian Bunk
2006-03-25 16:57 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060322235721.GF7844@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox